Re: [PATCH 1/4] X86: Revamp reboot behaviour to match Windows more closely

Rafael J. Wysocki
2011-03-11T22:18:08Z

On Friday, March 11, 2011, Matthew Garrett wrote:
> On Fri, Mar 11, 2011 at 11:08:18PM +0100, Rafael J. Wysocki wrote:
> > On Friday, March 11, 2011, Matthew Garrett wrote:
> > > Windows reboots by hitting the ACPI reboot vector (if available), trying
> > > the keyboard controller, hitting the ACPI reboot vector again and then
> > > giving the keyboard controller one last go. Rework our reboot process a
> > > little to default to matching this behaviour, although we'll fall through
> > > to attempting a triple fault if nothing else works.
> >
> > Does this fix a particular problem observed in practice?
>
> Yup. We're seeing an increasing number of machines that don't implement
> the legacy keyboard controller at all and fail to reboot if you poke it.
> The expectation appears to be that you use the ACPI reboot vector on
> these machines.

So perhaps you can put a pointer or two into the changelog? That would
show precisely that it's not just for pure Windows compatibility.

Thanks,
Rafael