Re: [PATCH 3/3] acpi: Split out custom_method functionality into an own driver

Thomas Renninger
2011-04-01T07:47:57Z

On Thursday, March 31, 2011 11:41:24 PM Rafael J. Wysocki wrote:
> On Thursday, March 31, 2011, Thomas Renninger wrote:
> > With /sys/kernel/debug/acpi/custom_method root can write
> > to arbitrary memory and increase his priveleges, even if
> > these are restricted.
> >
> > -> Make this an own debug .config option and warn about the
> > security issue in the config description.
> >
> > -> Still keep acpi/debugfs.c which now only creates and empty
> > /sys/kernel/debug/acpi directory. There might be other
> > users of it later.
> >
> > Signed-off-by: Thomas Renninger <trenn@suse.de>
> > CC: Rafael J. Wysocki <rjw@sisk.pl>
> > CC: lenb@kernel.org
> > CC: rui.zhang@intel.com
> > CC: linux-acpi@vger.kernel.org
> > ---
> > Documentation/acpi/method-customizing.txt | 5 ++
> > drivers/acpi/Kconfig | 15 +++++
> > drivers/acpi/Makefile | 1 +
> > drivers/acpi/debugfs.c | 80
+----------------------------
> > 4 files changed, 22 insertions(+), 79 deletions(-)
>
> Did you forget to custom_method.c ?
Indeed. Happened already, looks like I need a guilt add
again after guilt push -f, no idea.

Resend coming in a second.

Thanks,

Thomas