From: Len Brown <lenb@kernel.org>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: linux-acpi@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Huang Ying <ying.huang@intel.com>
Subject: Re: linux-next: Tree for July 20 (acpi/apei/ghes)
Date: Tue, 02 Aug 2011 18:05:00 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.02.1108021803530.25237@x980> (raw)
In-Reply-To: <20110720093829.aae2ec63.rdunlap@xenotime.net>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1273 bytes --]
From: Len Brown <len.brown@intel.com>
Subject: [PATCH] APEI GHES: 32-bit buildfix
drivers/acpi/apei/ghes.c:542: warning: integer overflow in expression
drivers/acpi/apei/ghes.c:619: warning: integer overflow in expression
ghes.c:(.text+0x46289): undefined reference to `__udivdi3'
in function ghes_estatus_cache_add().
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/apei/ghes.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index e92c47c..0784f99 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -65,7 +65,7 @@
#define GHES_ESTATUS_CACHES_SIZE 4
-#define GHES_ESTATUS_IN_CACHE_MAX_NSEC (10 * NSEC_PER_SEC)
+#define GHES_ESTATUS_IN_CACHE_MAX_NSEC 10000000000ULL
/* Prevent too many caches are allocated because of RCU */
#define GHES_ESTATUS_CACHE_ALLOCED_MAX (GHES_ESTATUS_CACHES_SIZE * 3 / 2)
@@ -622,7 +622,8 @@ static void ghes_estatus_cache_add(
break;
}
count = atomic_read(&cache->count);
- period = duration / (count + 1);
+ period = duration;
+ do_div(period, (count + 1));
if (period > max_period) {
max_period = period;
slot = i;
--
1.7.6.396.ge0613
prev parent reply other threads:[~2011-08-02 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110720180041.5774ca335e6697c17374dca5@canb.auug.org.au>
2011-07-20 16:36 ` linux-next: Tree for July 20 (acpi/apei/ghes) Randy Dunlap
2011-07-20 16:38 ` Randy Dunlap
2011-07-20 22:06 ` Sedat Dilek
2011-08-02 22:05 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1108021803530.25237@x980 \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox