Re: linux-next: Tree for July 20 (acpi/apei/ghes)

Re: linux-next: Tree for July 20 (acpi/apei/ghes)

[Randy Dunlap]

On Wed, 20 Jul 2011 18:00:41 +1000 Stephen Rothwell wrote:

> Hi all,

On i386 (X86_32):

drivers/acpi/apei/ghes.c:542: warning: integer overflow in expression
drivers/acpi/apei/ghes.c:619: warning: integer overflow in expression

ghes.c:(.text+0x46289): undefined reference to `__udivdi3'
  in function ghes_estatus_cache_add().

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: linux-next: Tree for July 20 (acpi/apei/ghes)

[Randy Dunlap]

On Wed, 20 Jul 2011 09:36:33 -0700 Randy Dunlap wrote:

> On Wed, 20 Jul 2011 18:00:41 +1000 Stephen Rothwell wrote:
> 
> > Hi all,
> 
> On i386 (X86_32):
> 
> drivers/acpi/apei/ghes.c:542: warning: integer overflow in expression
> drivers/acpi/apei/ghes.c:619: warning: integer overflow in expression
> 
> ghes.c:(.text+0x46289): undefined reference to `__udivdi3'
>   in function ghes_estatus_cache_add().

That's on:
		period = duration / (count + 1);

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: linux-next: Tree for July 20 (acpi/apei/ghes)

[Sedat Dilek]

On Wed, Jul 20, 2011 at 6:38 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Wed, 20 Jul 2011 09:36:33 -0700 Randy Dunlap wrote:
>
>> On Wed, 20 Jul 2011 18:00:41 +1000 Stephen Rothwell wrote:
>>
>> > Hi all,
>>
>> On i386 (X86_32):
>>
>> drivers/acpi/apei/ghes.c:542: warning: integer overflow in expression
>> drivers/acpi/apei/ghes.c:619: warning: integer overflow in expression
>>
>> ghes.c:(.text+0x46289): undefined reference to `__udivdi3'
>>   in function ghes_estatus_cache_add().
>
> That's on:
>                period = duration / (count + 1);
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Same here on i386 with CONFIG_ACPI_APEI_GHES=y.

  LD      .tmp_vmlinux1
drivers/built-in.o: In function `ghes_estatus_cache_add':
ghes.c:(.text+0x43d91): undefined reference to `__udivdi3'
make[4]: *** [.tmp_vmlinux1] Error 1

- Sedat -

Re: linux-next: Tree for July 20 (acpi/apei/ghes)

[Len Brown]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1273 bytes --]

From: Len Brown <len.brown@intel.com>
Subject: [PATCH] APEI GHES: 32-bit buildfix

drivers/acpi/apei/ghes.c:542: warning: integer overflow in expression
drivers/acpi/apei/ghes.c:619: warning: integer overflow in expression

ghes.c:(.text+0x46289): undefined reference to `__udivdi3'
  in function ghes_estatus_cache_add().

Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Len Brown <len.brown@intel.com>
---
 drivers/acpi/apei/ghes.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index e92c47c..0784f99 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -65,7 +65,7 @@
 
 #define GHES_ESTATUS_CACHES_SIZE	4
 
-#define GHES_ESTATUS_IN_CACHE_MAX_NSEC	(10 * NSEC_PER_SEC)
+#define GHES_ESTATUS_IN_CACHE_MAX_NSEC	10000000000ULL
 /* Prevent too many caches are allocated because of RCU */
 #define GHES_ESTATUS_CACHE_ALLOCED_MAX	(GHES_ESTATUS_CACHES_SIZE * 3 / 2)
 
@@ -622,7 +622,8 @@ static void ghes_estatus_cache_add(
 			break;
 		}
 		count = atomic_read(&cache->count);
-		period = duration / (count + 1);
+		period = duration;
+		do_div(period, (count + 1));
 		if (period > max_period) {
 			max_period = period;
 			slot = i;
-- 
1.7.6.396.ge0613