public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@elte.hu>, Mel Gorman <mgorman@suse.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	bruno@ioda-net.ch, Matthew Garrett <mjg59@srcf.ucam.org>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] x86: Add reboot quirk for Dell Precision M4600
Date: Sat, 06 Aug 2011 11:31:35 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.02.1108061120150.3197@x980> (raw)
In-Reply-To: <24c471f7-80f5-4102-a12b-d6245c8d0921@email.android.com>

On Sat, 6 Aug 2011, H. Peter Anvin wrote:

> Ingo Molnar <mingo@elte.hu> wrote:
> 
> >* Mel Gorman <mgorman@suse.de> wrote:
> >
> >> ACPI reboot does not work for Dell Precision M4600. Detect this
> >> machine via DMI and force the use of the PCI reboot method.
> >>     
> >> Reported-and-tested-by: Bruno Friedmann <bruno@ioda-net.ch>
> >> Signed-off-by: Mel Gorman <mgorman@suse.de>
> >> ---
> >>  arch/x86/kernel/reboot.c |    9 +++++++++
> >>  1 files changed, 9 insertions(+), 0 deletions(-)
> >
> >Weird - ACPI is the default Windows method of reboot - how come it 
> >does not work on that box? Does Windows work around this specific 
> >machine (unlikely), or is our ACPI boot sequence not 100% compatible 
> >with the Windows method (more likely IMO)?
> 
> It seems almost all the affected machines are Dell, too... very odd, no?

Dell website says that the M4600 is current,
and ships with Windows 7.  It is a "mobile workstation",
so it is more likely to have a windows "feature" driver,
say, than Dell's servers.

Matthew,
Did you do your reboot comopatibility test using Win7,
or something older?

BTW, it would be nice if ACPI incompatibilities and workarounds
somehow got stuck in the ACPI code rather than the arch code.
Unfortunately this kind sets a working reboot method instead
of disabling a non-working one -- so what it overrides has
changed when the default changed.

thanks,
-Len Brown, Intel Open Source Technolgy Center


       reply	other threads:[~2011-08-06 15:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110727125651.GH3010@suse.de>
     [not found] ` <20110806065635.GE13220@elte.hu>
     [not found]   ` <24c471f7-80f5-4102-a12b-d6245c8d0921@email.android.com>
2011-08-06 15:31     ` Len Brown [this message]
2011-08-06 18:18       ` [PATCH] x86: Add reboot quirk for Dell Precision M4600 Bruno Friedmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1108061120150.3197@x980 \
    --to=lenb@kernel.org \
    --cc=bruno@ioda-net.ch \
    --cc=hpa@zytor.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@elte.hu \
    --cc=mjg59@srcf.ucam.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox