From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH v3 1/3] aerdrv: Trace Event for AER Date: Sat, 1 Dec 2012 11:28:25 -0200 (BRST) Message-ID: References: <20121130213330.7649.51101.stgit@grignak.americas.hpqcorp.net> <20121201093614.720aa96a@redhat.com> <20121201114310.GA7853@liondog.tnic> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Return-path: In-Reply-To: <20121201114310.GA7853@liondog.tnic> Sender: linux-pci-owner@vger.kernel.org To: Borislav Petkov Cc: Mauro Carvalho Chehab , Lance Ortiz , bhelgaas@google.com, lance_ortiz@hotmail.com, jiang.liu@huawei.com, tony.luck@intel.com, rostedt@goodmis.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-acpi@vger.kernel.org Cheers, Mauro On Sat, 1 Dec 2012, Borislav Petkov wrote: > On Sat, Dec 01, 2012 at 09:36:14AM -0200, Mauro Carvalho Chehab wrote: >> Please don't call it as "ras.h". Call it, instead, ras_aer.h >> (or something similar) as, if we're moving the tracing back to >> include/trace/events/, the same should happen for the memory error >> events. > > As you can see yourself, include/trace/events/ contains one header per > topic so having ras_event.h and ras_aer.h or whatever, doesn't fit the > scheme. IOW, we want all RAS-specific tracepoints to be collected in a > header called ras.h like the rest of the subsystems do it. See rcu.h > there for a good example. Works for me. Regards, Mauro