From: Thomas Gleixner <tglx@linutronix.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Yinghai Lu <yinghai@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Toshi Kani <toshi.kani@hp.com>, Huang Ying <ying.huang@intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [BUG bisected]: apei_hest_parse explosion
Date: Fri, 22 Feb 2013 09:22:15 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.02.1302220903000.22263@ionos> (raw)
In-Reply-To: <4867361.uTndA5QxsU@vostro.rjw.lan>
On Fri, 22 Feb 2013, Rafael J. Wysocki wrote:
> On Friday, February 22, 2013 02:40:58 AM Rafael J. Wysocki wrote:
> > It looks like the hest_tab memory mapping is unmapped between acpi_hest_init()
> > and aer_acpi_firmware_first(), but I have no idea what may be responsible for
> > that.
> >
> > And the only relevant difference between now and before the commit above seems
> > to be the change of the acpi_hest_init() ordering (which now is called earlier).
>
> We actually don't really need to do that thing so early, I think. It looks like
> we only need to make it available early enough for the AER driver to be able to
> use it, so I wonder if moving the acpi_hest_init() to a separate
> subsys_initcall() will work around the problem. That is, something like the
> patch below.
Yes, that makes the machine boot.
> But even if this helps, I will be wanting to understand what's up here.
It's very simple. I have "acpi=off" on the command line. With that
acpi_hest_init is never called, so hest_disable is not set .....
Brilliant stuff that.
next prev parent reply other threads:[~2013-02-22 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.02.1302220002040.22263@ionos>
[not found] ` <1447813.geP1BIVYu5@vostro.rjw.lan>
[not found] ` <CAE9FiQXV43emyjjCb=D=xFLz-n6q0Eu0uQmVhAA470A=FGRhww@mail.gmail.com>
2013-02-22 1:40 ` [BUG bisected]: apei_hest_parse explosion Rafael J. Wysocki
2013-02-22 2:19 ` Rafael J. Wysocki
2013-02-22 8:22 ` Thomas Gleixner [this message]
2013-02-22 12:30 ` Rafael J. Wysocki
2013-02-22 14:39 ` Thomas Gleixner
2013-02-22 21:00 ` Rafael J. Wysocki
2013-02-22 23:46 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1302220903000.22263@ionos \
--to=tglx@linutronix.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=toshi.kani@hp.com \
--cc=ying.huang@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox