From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [BUG bisected]: apei_hest_parse explosion Date: Fri, 22 Feb 2013 15:39:44 +0100 (CET) Message-ID: References: <4867361.uTndA5QxsU@vostro.rjw.lan> <5350252.GArARx6b7p@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from www.linutronix.de ([62.245.132.108]:58007 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756216Ab3BVOjw (ORCPT ); Fri, 22 Feb 2013 09:39:52 -0500 In-Reply-To: <5350252.GArARx6b7p@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Yinghai Lu , LKML , Toshi Kani , Huang Ying , ACPI Devel Maling List On Fri, 22 Feb 2013, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Subject: ACPI / APEI: Fix crash in apei_hest_parse() for acpi=off > > After commit 92ef2a2 (ACPI: Change the ordering of PCI root bridge > driver registrarion), acpi_hest_init() is never called for acpi=off > (acpi_disabled), so hest_disable is not set, but hest_tab is NULL, > which causes apei_hest_parse() to crash when it is called from > aer_acpi_firmware_first(). > > Fix that by making apei_hest_parse() check if hest_tab is not NULL > in addition to checking hest_disable. Also remove the now useless > acpi_disabled check from apei_hest_parse(). > > Reported-by: Thomas Gleixner > Signed-off-by: Rafael J. Wysocki Tested-by: Thomas Gleixner