From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [Patch V4 11/42] x86, ioapic: kill unused global variable
 timer_through_8259
Date: Mon, 9 Jun 2014 15:41:12 +0100 (BST)
Message-ID: <alpine.LFD.2.11.1406091538320.14982@eddie.linux-mips.org>
References: <1402302011-23642-1-git-send-email-jiang.liu@linux.intel.com> <1402302011-23642-12-git-send-email-jiang.liu@linux.intel.com>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Return-path: <linux-pci-owner@vger.kernel.org>
Received: from localhost.localdomain ([127.0.0.1]:35751 "EHLO
        localhost.localdomain" rhost-flags-OK-OK-OK-OK)
        by eddie.linux-mips.org with ESMTP id S6822318AbaFIOlMtHKhH (ORCPT
        <rfc822;linux-acpi@vger.kernel.org> + 2 others);
        Mon, 9 Jun 2014 16:41:12 +0200
In-Reply-To: <1402302011-23642-12-git-send-email-jiang.liu@linux.intel.com>
Sender: linux-pci-owner@vger.kernel.org
To: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>, Thomas Gleixner <tglx@linutronix.de>, Grant Likely <grant.likely@linaro.org>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Bjorn Helgaas <bhelgaas@google.com>, Randy Dunlap <rdunlap@infradead.org>, Yinghai Lu <yinghai@kernel.org>, x86@kernel.org, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Andrew Morton <akpm@linux-foundation.org>, Tony Luck <tony.luck@intel.com>, Joerg Roedel <joro@8bytes.org>, Paul Gortmaker <paul.gortmaker@windriver.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Ingo Molnar <mingo@kernel.org>
List-Id: linux-acpi@vger.kernel.org

On Mon, 9 Jun 2014, Jiang Liu wrote:

> index d4aba16e6bbf..94a56c233e87 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -2638,8 +2638,6 @@ static int __init disable_timer_pin_setup(char *arg)
>  }
>  early_param("disable_timer_pin_1", disable_timer_pin_setup);
>  
> -int timer_through_8259 __initdata;
> -
>  /*
>   * This code may look a bit paranoid, but it's supposed to cooperate with
>   * a wide range of boards and BIOS bugs.  Fortunately only the timer IRQ
> @@ -2744,7 +2742,6 @@ static inline void __init check_timer(void)
>  		legacy_pic->unmask(0);
>  		if (timer_irq_works()) {
>  			apic_printk(APIC_QUIET, KERN_INFO "....... works.\n");
> -			timer_through_8259 = 1;
>  			goto out;
>  		}
>  		/*

 So how does the new NMI watchdog handle systems that use this '8259A 
Virtual Wire' mode, pretty common on pre-P6 computers?

  Maciej