From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Stefan Binding <sbinding@opensource.cirrus.com>,
alsa-devel@alsa-project.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
patches@opensource.cirrus.com,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v5 2/2] ASoC: cs35l41: Read System Name from ACPI _SUB to identify firmware
Date: Thu, 30 Jun 2022 14:50:10 -0500 [thread overview]
Message-ID: <b080405b-d1af-8a32-a429-b09250489f0c@linux.intel.com> (raw)
In-Reply-To: <Yr36wcXf1/bNS0a3@sirena.org.uk>
On 6/30/22 14:34, Mark Brown wrote:
> On Thu, Jun 30, 2022 at 01:35:05PM -0500, Pierre-Louis Bossart wrote:
>
>> It's my understanding that the _SUB method is optional, not required. It
>> may be wise to plan for a fallback, e.g to use DMI quirks or other
>> identifiers, no?
>
> Presumably the fallback would go into cs35l41_acpi_get_name()?
That's what I had in mind, if this _SUB does not exist then you could
use something else instead of returning -ENODATA;
+ sub = acpi_get_subsystem_id(handle);
+ if (IS_ERR(sub))
+ return PTR_ERR(sub);
+
+ cs35l41->dsp.system_name = sub;
prev parent reply other threads:[~2022-06-30 19:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 15:01 [PATCH v5 0/2] Read _SUB from ACPI to be able to identify firmware Stefan Binding
2022-06-30 15:01 ` [PATCH v5 1/2] ACPI: utils: Add api to read _SUB from ACPI Stefan Binding
2022-07-05 16:00 ` Rafael J. Wysocki
2022-07-05 19:04 ` Andy Shevchenko
2022-06-30 15:01 ` [PATCH v5 2/2] ASoC: cs35l41: Read System Name from ACPI _SUB to identify firmware Stefan Binding
2022-06-30 18:35 ` Pierre-Louis Bossart
2022-06-30 19:34 ` Mark Brown
2022-06-30 19:50 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b080405b-d1af-8a32-a429-b09250489f0c@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rafael@kernel.org \
--cc=sbinding@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox