From: "Zhang, Rui" <rui.zhang@intel.com>
To: "ggherdovich@suse.cz" <ggherdovich@suse.cz>,
"rafael@kernel.org" <rafael@kernel.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 2/2] ACPI: processor: idle: Remove obsolete comment
Date: Wed, 9 Apr 2025 00:54:17 +0000 [thread overview]
Message-ID: <b29519a2da5b85f484b0f402062df2b58ec38afe.camel@intel.com> (raw)
In-Reply-To: <20250328143040.9348-2-ggherdovich@suse.cz>
On Fri, 2025-03-28 at 15:30 +0100, Giovanni Gherdovich wrote:
> Since commit 496121c02127e9c460b436244c38260b044cc45a ("ACPI:
> processor:
> idle: Allow probing on platforms with one ACPI C-state"), the comment
> doesn't reflect the code anymore; remove it.
>
> Signed-off-by: Giovanni Gherdovich <ggherdovich@suse.cz>
This is a standalone cleanup, and further cleanups are posted in a
separate patch set on top of this one, so
Acked-by: Zhang Rui <rui.zhang@intel.com>
> ---
> drivers/acpi/processor_idle.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/acpi/processor_idle.c
> b/drivers/acpi/processor_idle.c
> index b181f7fc2090..2a076c7a825a 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -482,10 +482,6 @@ static int acpi_processor_get_cstate_info(struct
> acpi_processor *pr)
>
> pr->power.count = acpi_processor_power_verify(pr);
>
> - /*
> - * if one state of type C2 or C3 is available, mark this
> - * CPU as being "idle manageable"
> - */
> for (i = 1; i < ACPI_PROCESSOR_MAX_POWER; i++) {
> if (pr->power.states[i].valid) {
> pr->power.count = i;
next prev parent reply other threads:[~2025-04-09 0:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 14:30 [PATCH 1/2] ACPI: processor: idle: Return an error if both P_LVL{2,3} idle states are invalid Giovanni Gherdovich
2025-03-28 14:30 ` [PATCH 2/2] ACPI: processor: idle: Remove obsolete comment Giovanni Gherdovich
2025-03-31 7:38 ` Zhang, Rui
2025-03-31 12:07 ` Rafael J. Wysocki
2025-04-01 0:25 ` Zhang, Rui
2025-04-01 12:13 ` Rafael J. Wysocki
2025-04-03 1:11 ` Zhang, Rui
2025-04-03 10:42 ` Rafael J. Wysocki
2025-04-09 0:54 ` Zhang, Rui [this message]
2025-04-09 12:54 ` Rafael J. Wysocki
2025-03-31 1:08 ` [PATCH 1/2] ACPI: processor: idle: Return an error if both P_LVL{2,3} idle states are invalid Zhang, Rui
2025-03-31 12:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b29519a2da5b85f484b0f402062df2b58ec38afe.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=ggherdovich@suse.cz \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox