From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0D1C433EF for ; Mon, 25 Apr 2022 14:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233035AbiDYObZ (ORCPT ); Mon, 25 Apr 2022 10:31:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbiDYObW (ORCPT ); Mon, 25 Apr 2022 10:31:22 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8393760E7; Mon, 25 Apr 2022 07:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650896898; x=1682432898; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=9yiIvOpFN10cIS1wzTK8JtifZSuLedCuEV0Q+urka+8=; b=Hd4DZaGFgSC6AX92hqDxNhN8LpzcNE/9x+/5kLL4dhZowm80cVR5qVJa Yt2ZW4duuGgzlLK3y4ZINSijkI7PxMAB8+doPahr+HNMuQk+/1ktnimOK omWZn5P0KYtyJEC+Mg6t/CWUjQkIMmE3MaqFpDilxVkbCvUq1nWrZ3ikc l1M8gZRRyq1njY8nD/4wFvnNqc0iIGYzTq5uKIRXhQzXYDfzG6G/53bX9 DSqNohXyOb7bVbEK5bj/B9leaDLvH08REQ7Bni6ivrPFlcAviPC/KomM0 +0Xjva2ZRKB23wlFfy2Cx+mEi34CokZVtNfic2a2ZfZaGTFHjcIAgWwQR A==; X-IronPort-AV: E=McAfee;i="6400,9594,10328"; a="262859106" X-IronPort-AV: E=Sophos;i="5.90,288,1643702400"; d="scan'208";a="262859106" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2022 07:27:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,288,1643702400"; d="scan'208";a="677163366" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 25 Apr 2022 07:27:55 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 25 Apr 2022 07:27:55 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 25 Apr 2022 07:27:54 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 25 Apr 2022 07:27:54 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 25 Apr 2022 07:27:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dCj8m+qIdcsPyCurzR5FqiSk3hgDHntP4eyQKoDe3u+21sr/EsFKK2lEcRJ7ek/1L+0Hom1RTgpo6Pi0Dr7JYJQLMJYAHyGG/MkuKl1lXOOnfczar6KTTqV1jkO8dEuzpNY4QcTjkrNqde1jvh9wHPxCUb/yfGMR95tlRCv8G8llI1CwCgrt6233vU3k/lFIRLITfK2EyaWHPT6bjPrQPdQmNdnQXKr/zqgJY4igwcaLueEr+YEgvK+CKZW6AVtstOVwdO+9dNhMD9pI7ZTQibgqSu5QgSErXybs5sWSmyyDNIJCPL2UkUb3Mrq8Btl/Uxw1FUPxkAOdpddln7i2UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HUz2rkb1DR7nShT4DYzudMgCGH95rUwKnyF/akCXFP0=; b=Bu1MGmwTCBEwiXnWO754UToJKJxsqev86ZsPC8gM+HnggjdoM8tKmCjhOlOlwigrQXmEt5Jyy34OPuz6jgCzXzH6MIhCFluU7gA67oPUEfh9Y93nlEi0JxeQBfMskFblLGx3ZMy2XZ4LQ18USnIIpLD7xvEwFPDM3RFxWU2uVXSRnsrE++MDGawNgbxSx0gWyHwRMKwrAsnF7MZKC633lQ32OcRnEVXbpE0RkVHAsgT+bR3pe8NWRL4pwE6bTqAqUtBkmHAEJdeJLQLhdF2RYa9lsi1FB0xOnSpSvbeC/okN7/NOyg32sLLgMdcp12Tz14B0r/vmpKcIGbcviWXbjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW5PR11MB5810.namprd11.prod.outlook.com (2603:10b6:303:192::22) by BL0PR11MB3363.namprd11.prod.outlook.com (2603:10b6:208:6f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Mon, 25 Apr 2022 14:27:52 +0000 Received: from MW5PR11MB5810.namprd11.prod.outlook.com ([fe80::98d8:aa81:9f56:c36a]) by MW5PR11MB5810.namprd11.prod.outlook.com ([fe80::98d8:aa81:9f56:c36a%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022 14:27:52 +0000 Message-ID: Date: Mon, 25 Apr 2022 16:27:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.8.1 Subject: Re: [PATCH v6 0/3] PCI/ACPI: add support for CXL _OSC Content-Language: en-US To: "Verma, Vishal L" , "linux-cxl@vger.kernel.org" CC: "Jonathan.Cameron@Huawei.com" , "a.manzanares@samsung.com" , "Williams, Dan J" , "linux-acpi@vger.kernel.org" , "Moore, Robert" , "bhelgaas@google.com" , "dave@stgolabs.net" References: <20220413073618.291335-1-vishal.l.verma@intel.com> <4f277b84c2ee770f6a2706744b96fb1dfd6184a7.camel@intel.com> From: "Rafael J. Wysocki" Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego 173, 80-298 Gdansk In-Reply-To: <4f277b84c2ee770f6a2706744b96fb1dfd6184a7.camel@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::15) To MW5PR11MB5810.namprd11.prod.outlook.com (2603:10b6:303:192::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 322fcea2-81b3-4231-a737-08da26c7c826 X-MS-TrafficTypeDiagnostic: BL0PR11MB3363:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ev81MUr190gm3vxorJDZHk28AKeFyvv3dSae/ZcTzKLDzjpfQBSOy+ya3Q2xZP5nPuY7hMqrLi08SZV2D/TafDtQTi1jjKEseSlOsZnJfKI+B+3+HUauB/L6dd1ykHUmFUJa7Up7Yc9YyyafOes4S7kIKadiu8xdwjVca/mr8+FSztNIoNGocLfBMoipsNL+vO0Z+i5qkh7+rfQ0LoqO645WLScj6/dhG42JK2g5g1FuCRHc2gjpMx0ouBmcZ+TJwDgq1t8cGjLBA6mkyaNZ8bp3SQKCdFW9YDl56P13h+Y2Cd99kCsVHPzcFjk6Hx8RgYUgw7Qh/e4QormzdSCIPdo/+4Mk9j5DpOcUjEmlLPgx2wrCpelJK7V3nLs9zgp74cPX+CyWppihUi8k4EmqVVdgbGgIxnBIRNS542pRgIKiC7kFzQGp/LmOTJc3QkoQpkG01H97kBRGoc1DAa6rs7mTYj84fOn69akUo2p7QpNA2Ptuya+HkWLwd0uuippMsfVOAmH6CmR7AeeF9mhlTBDgG8AKHgYvUkZwHymZ3AJNzEKE5DT3ezFPcJfOtahy4LBf5u86mY9Fdus3GBkhZQdCVk5GfrHkeLorSECbAn7aqNc8fqm5i9QuUp0uA0/KC/0mpcF/8+wxwxJfkJRX6bWTXS5EarnhQtCRCeris8uGTgmSvKSMcodsISiVNK9jRTNZ42hpDuFkkr2TI//v7823Vb0TujrfaA79vM2y7JQ/e4VxX4g2lIUdjHzxAgsggwHoaM+yS/kFSsYu3G1qrRXx4B7bQvRDnR9WNXsV3s2mgToGeFiwSXPCc7Maw7FF2t8OMiQdTOYaB2Dy8CE3QPj0HRkJucZMcjSYyGAkQwM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5810.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(66476007)(54906003)(38100700002)(508600001)(6486002)(316002)(4326008)(966005)(110136005)(31696002)(8936002)(86362001)(36756003)(83380400001)(8676002)(66946007)(66556008)(2616005)(36916002)(6506007)(5660300002)(82960400001)(53546011)(6666004)(31686004)(2906002)(6512007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3NWbjVFcVhxdE9UOVFvUC9mdFVWU2JDc2E0cnM0MlE2WFdLZ0Q2R1hTeUd3?= =?utf-8?B?KzV5OW8xckhycmxWZDhWU3hzMk1NSjhyUGF4dFVUSmZ0RmtjaEJHVmkrQk9I?= =?utf-8?B?TC9TYTlCWW5la01aYUFPQkVDaGYzRWhuek4xVUFKK3JHcWJxcnVtSlJXdldT?= =?utf-8?B?eUQ0Y3B1YzJLOFdFZHJPUnBjS0VoRGNUMUV1U1laRUpTbUZEc285NDkxR0pP?= =?utf-8?B?UkRmbzhESkxLYWhiNS94WXBXT0lJRnlLWnNrWlo1TUdjWDYvUCt1N1ovc2po?= =?utf-8?B?d0t5U3NXcDQ4Y09POGpnUTJlaXBScmNmZDRMTURGNUp5a2NSdU52K2FLNGkz?= =?utf-8?B?QmlSb2NNbEkwS3NoTHhTVndaanFSZE9yeVZJWEthNytNQjJnbmNHWnhTeDQ1?= =?utf-8?B?SDAvTGRtVjdYNlMxZCtlK2wzenNpc1BmbExYd2N4R1FYTERZQStPZkwwaEJQ?= =?utf-8?B?c1BPOGRKdDlRdVNzdlB1NGZ6dFoxQzdXWHlRRnh3TlVPeFVsMnU3R1dBeXk0?= =?utf-8?B?dkIvSFU5TFQ0RlNHWDdBYVhmTXRQdW81L0I3VnVuRSt4T0F4VXprQVIzaWpS?= =?utf-8?B?NEorQnAyaHgvZUdBYnY5SmVLZytXU1BXQmFVSExwOEgxdXJubE8rdGVIM1FU?= =?utf-8?B?MExJLzdPaThYVkxhMlJtWkl6U24vaWYzdm5kUFRSeE8zU0VHcmZ3YnVCaGw0?= =?utf-8?B?SXcwTXQ4TmxHYVE3aXZWZnF5dWZZUFd2UXhYQ3FENlp1cTRDSGI0YllUcWtm?= =?utf-8?B?RiswRGdSTzBQcFV4SzNiMGdhZkEwaEorS0ZhNC90OWdFUVVpS0NzTmtDNWwz?= =?utf-8?B?MkhNWTNFTkgra0pLZm82SGdwV0FJN0JndmpZaC9TR0J1dExQbkZqMmtYMXJj?= =?utf-8?B?cHA4WTE3bFVnaEhKTGd5L2hVTFdZMFk0SFFsUzJqUEcxTGdzREdTbEtCV050?= =?utf-8?B?L1hiR1JXMVNuSzd2dUF1bVplU1Y1WG1rYnFKTWlnczZBUUkyQWtzbUJVNUNv?= =?utf-8?B?c0xFUlVkc2NTVmtrK2V1QzUrZkJHMHpaWE9kOVVmT1NGWUM5Nmc0SGpyeVQw?= =?utf-8?B?VytZd1A5QkxzVXE2bmM3TTVieVEybERmQnVocjdqcXVYTTRQOUFpTTRadFpZ?= =?utf-8?B?ajU5clN3eXlZSnh5bzVJY1BVVmZkSWlvVmxpWlZncXhDWWlpd01oQXhwcVFY?= =?utf-8?B?NGhYV3E0ZkJhWjNwSnN6QUhzNWo3ZzZUUGhyamtkazQrUXdnbVZLWG0vRnRw?= =?utf-8?B?NTBFL3hUaHg5c1FMQjAvdFdUd3JGSWQ5WHMrVVlEUW1pcWZpa3hZeTN3UTNL?= =?utf-8?B?Q2E3MjQ0SDA3amczYmZac1UxOXpaYS9IRjQxTzkwWDVMRnIyR2Z5blZ3Sm1U?= =?utf-8?B?SUY2WUl0NkgvYU03MHVoUU9xVzNxamMzVW4vQUdEV2ZMTHNvd1dObFFuTFpv?= =?utf-8?B?NlJ2N2N1aGFsQzlaLy96eXJrUnppb1VCZzZtRkRZVWFRQksvVkVFci84UTlm?= =?utf-8?B?QStzWTR1ekdCeTluWStGQk9IcjJSbmY3QjNZeE5hQVZtS0pCUjZnY0dNOHdO?= =?utf-8?B?ejVhaTVGZjFBVkVTZUVRLzlHSXFkMDhyMllsRGlNYVZVcUtmdW4wb1B5OFB5?= =?utf-8?B?NmdMTUVxZnBRUzdCTTd6S3JidTdzTGExQTJqamFXU2p6OWNiUEU3Rjl3WkE1?= =?utf-8?B?N2M5eXNGZm1XTHh0OGFBYnU0S25pOWtNaDhTNVRpOW5jbGVZenY0Y0pUdkFP?= =?utf-8?B?OWUyWUpwOWhXci95bDlHOERzUjkrMGtqdHNxcmdSQjB2OC9DMzFCeE9Ycmlq?= =?utf-8?B?RG8xbDdEUDg4YkNPWW1OWnBZRTVpRm1wb2VPanFWZW1QczNQR2I5NFRVNXJG?= =?utf-8?B?TUM4YkEyMnR3bzVNVTNIMnFWVE9qYmozbXQwaUE4b1RJNVhHMmJML2tCUmtV?= =?utf-8?B?N3Uzb09XR01ORUVyYlhyQkVadDZnTm15UEFqSUhxZ3RtUWp0YXBpaWdJb1VW?= =?utf-8?B?alRjQ3UrbjdmeFAzcVhMZFN0aXF4QnpSL3N6RjRHalJTZHRMNzhEaHFSQUhP?= =?utf-8?B?K3JRYzZKekhFU0E4L0E0RXVPM1ZLLzNpREdKN2FkNkN3dSs4bVNySFdpbFZx?= =?utf-8?B?WklqYW1WYWY4dWpvSEVwdy9iYytISDM1amFKYVVFQTkxZUhBWHVYdncyQnQ1?= =?utf-8?B?SkwwdEZBcE9WeEx4OWQzRlY2OWhvN2lNQUF5SVVpYWxIYVpGVEErZ1Uyem5z?= =?utf-8?B?RWp5NFVYanA4VkhUY05XZGVxelY2T2t1VHpGZHFraEUzblZTUkw5M0VkTzZM?= =?utf-8?B?SzJWNUtlS01LQnNjTjdCdmExbCtCNFhoMkxrVzZGUHlOS0dOYkdGR3pjYXdH?= =?utf-8?Q?Rbs7hkc8DMuOOmNE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 322fcea2-81b3-4231-a737-08da26c7c826 X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 14:27:52.7498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vKJKTRjg9GgBOI7L6BeWfX4rGYFaWH2i1deKWAqwUd69z8J3PIsfPXO26OP0vFO7sh7BaFCUF6r6BydN9odXQ8ddM4KAJRez7A/VPJTm+1s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3363 X-OriginatorOrg: intel.com Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 4/23/2022 12:24 AM, Verma, Vishal L wrote: > On Wed, 2022-04-13 at 01:36 -0600, Vishal Verma wrote: >> Changes since v5[1]: >> - Collect an reviewed-by tags from Rafael, Adam, and David >> - Fix a couple of missed s/CXL/extended/ in acpi_bus.h (Rafael) > Rafael, or Bjorn, > > Dan has offered to take this through cxl.git. Any objections to that - > would you prefer it to go through either the PCI or ACPI trees instead? This would be fine with me, but I can take the series too. >> Add support for using the CXL definition of _OSC where applicable, and >> negotiating CXL specific support and control bits. >> >> Patch 1 is a preliminary cleanup that replaces open-coded pointer >> arithmetic to retrieve the Control DWORD with an inline helper. >> >> Patch 2 adds the new CXL _OSC UUID, and uses it instead of the PCI UUID >> when a root port is CXL enabled. It provides a fallback method for >> CXL-1.1 platforms that may not implement the CXL-2.0 _OSC. >> >> Patch 3 performs negotiation for the CXL specific _OSC support and >> control bits. >> >> I've tested these against a custom qemu[2], which adds the CXL _OSC (in >> addition to other CXL support). Specifically, _OSC support is added >> here[3]. >> >> [1]: https://lore.kernel.org/linux-cxl/20220406023746.2807328-1-vishal.l.verma@intel.com >> [2]: https://gitlab.com/jic23/qemu/-/tree/cxl-v8-draft >> [3]: https://gitlab.com/jic23/qemu/-/commit/1d67df6b6e3716c27462873f3451956f5c0673a3 >> >> Dan Williams (1): >>   PCI/ACPI: Prefer CXL _OSC instead of PCIe _OSC for CXL host bridges >> >> Vishal Verma (2): >>   PCI/ACPI: add a helper for retrieving _OSC Control DWORDs >>   PCI/ACPI: negotiate CXL _OSC >> >>  include/linux/acpi.h    |  42 ++++++- >>  include/acpi/acpi_bus.h |  12 +- >>  drivers/acpi/bus.c      |   2 +- >>  drivers/acpi/pci_root.c | 240 +++++++++++++++++++++++++++++++++++----- >>  4 files changed, 262 insertions(+), 34 deletions(-) >> >> >> base-commit: 05e815539f3f161585c13a9ab023341bade2c52f