From: Sinan Kaya <okaya@codeaurora.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
dmaengine <dmaengine@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH v1 1/4] ACPI / bus: Remove checks in acpi_get_match_data()
Date: Wed, 31 Jan 2018 17:17:23 -0500 [thread overview]
Message-ID: <b52b3995-ec9c-660d-6c2f-afebf3864b90@codeaurora.org> (raw)
In-Reply-To: <20180131212959.68766-1-andriy.shevchenko@linux.intel.com>
On 1/31/2018 4:29 PM, Andy Shevchenko wrote:
> As well as its sibling of_device_get_match_data() has no such checks,
> no need to do it in acpi_get_match_data().
>
> First of all, we are not supposed to call fwnode API like this without
> driver attached.
>
> Second, if pure OF driver calls this function, it's weird to have ACPI
> companion without ACPI ID in this case.
We talked about this during review.
of_match_device() does all the checking for the OF part. ACPI doesn't have
any checks.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-01-31 22:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 21:29 [PATCH v1 1/4] ACPI / bus: Remove checks in acpi_get_match_data() Andy Shevchenko
2018-01-31 21:29 ` [PATCH v1 2/4] ACPI / bus: Rename acpi_get_match_data() to acpi_device_get_match_data() Andy Shevchenko
2018-01-31 21:29 ` [PATCH v1 3/4] dmaengine: hidma: Constify returned by device_get_match_data() value Andy Shevchenko
2018-02-03 17:16 ` kbuild test robot
2018-01-31 21:29 ` [PATCH v1 4/4] device property: Constify device_get_match_data() Andy Shevchenko
2018-01-31 22:17 ` Sinan Kaya [this message]
2018-02-01 7:27 ` [PATCH v1 1/4] ACPI / bus: Remove checks in acpi_get_match_data() Rafael J. Wysocki
2018-02-01 12:24 ` Andy Shevchenko
2018-02-01 12:58 ` okaya
2018-02-02 11:32 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b52b3995-ec9c-660d-6c2f-afebf3864b90@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).