RE: [PATCH v13 1/2] ACPI / APEI: Add a notifier chain for unknown (vendor) CPER records

Shiju Jose
2020-07-31T14:07:17Z

Hi James,

>-----Original Message-----
>From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-
>owner@vger.kernel.org] On Behalf Of James Morse
>Sent: 31 July 2020 14:48
>To: Shiju Jose <shiju.jose@huawei.com>
>Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux-
>acpi@vger.kernel.org; linux-pci@vger.kernel.org; linux-
>kernel@vger.kernel.org; rjw@rjwysocki.net; helgaas@kernel.org;
>bp@alien8.de; lenb@kernel.org; tony.luck@intel.com;
>dan.carpenter@oracle.com; zhangliguang@linux.alibaba.com; Wangkefeng
>(OS Kernel Lab) <wangkefeng.wang@huawei.com>; jroedel@suse.de;
>Linuxarm <linuxarm@huawei.com>; yangyicong <yangyicong@huawei.com>;
>Jonathan Cameron <jonathan.cameron@huawei.com>; tanxiaofei
><tanxiaofei@huawei.com>
>Subject: Re: [PATCH v13 1/2] ACPI / APEI: Add a notifier chain for unknown
>(vendor) CPER records
>
>Hi Shiju,
>
>On 22/07/2020 13:50, Andy Shevchenko wrote:
>> On Wed, Jul 22, 2020 at 12:34:23PM +0000, Shiju Jose wrote:
>
>>>>> Co-developed-by: James Morse <james.morse@arm.com>
>>>>
>>>> Co-developed-by: is going _in conjunction with_ SoB tag which is
>>>> missing here.
>>> This tag was added as per instruction from Rafael.
>>> I was told that I cannot add SoB tag for others unless specifically given.
>>> Probably I will leave it with Rafael/James to help on this SoB tag as
>>> Rafael was ok to merge this patch.
>>
>> I think it's a misunderstanding somewhere. According to [1]:
>> "Since Co-developed-by: denotes authorship, every Co-developed-by:
>> must be immediately followed by a Signed-off-by: of the associated co-
>author."
>>
>> It means either both or none.
>>
>> [1]:
>> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>
>Sorry for this mess! My intention was to summarise my suggestion in the
>form of a patch, I wasn't expecting you to pick it up. (and I didn't post it
>because there was ongoing discussion on the second part)
>
>I'll repost this with the Co-Developed-by stuff. You'll need to re-post it with
>the series, you'll need to move your Signed-Off-By to be last when you do
>that.

Sure. Thanks.
Also please consider make you as the author of this patch
because it has more changes from you.

>
>
>Thanks,
>
>James

Thanks,
Shiju