RE: [PATCH v13 1/2] ACPI / APEI: Add a notifier chain for unknown (vendor) CPER records

Shiju Jose
2020-07-22T12:34:26Z

Hi Andy,

>-----Original Message-----
>From: Andy Shevchenko [mailto:andriy.shevchenko@linux.intel.com]
>Sent: 22 July 2020 12:02
>To: Shiju Jose <shiju.jose@huawei.com>
>Cc: linux-acpi@vger.kernel.org; linux-pci@vger.kernel.org; linux-
>kernel@vger.kernel.org; rjw@rjwysocki.net; helgaas@kernel.org;
>bp@alien8.de; james.morse@arm.com; lenb@kernel.org;
>tony.luck@intel.com; dan.carpenter@oracle.com;
>zhangliguang@linux.alibaba.com; Wangkefeng (OS Kernel Lab)
><wangkefeng.wang@huawei.com>; jroedel@suse.de; Linuxarm
><linuxarm@huawei.com>; yangyicong <yangyicong@huawei.com>; Jonathan
>Cameron <jonathan.cameron@huawei.com>; tanxiaofei
><tanxiaofei@huawei.com>
>Subject: Re: [PATCH v13 1/2] ACPI / APEI: Add a notifier chain for unknown
>(vendor) CPER records
>
>On Wed, Jul 22, 2020 at 11:39:51AM +0100, Shiju Jose wrote:
>> CPER records describing a firmware-first error are identified by GUID.
>> The ghes driver currently logs, but ignores any unknown CPER records.
>> This prevents describing errors that can't be represented by a
>> standard entry, that would otherwise allow a driver to recover from an
>error.
>> The UEFI spec calls these 'Non-standard Section Body' (N.2.3 of
>> version 2.8).
>>
>> Add a notifier chain for these non-standard/vendor-records. Callers
>> must identify their type of records by GUID.
>>
>> Record data is copied to memory from the ghes_estatus_pool to allow us
>> to keep it until after the notifier has run.
>>
>> Co-developed-by: James Morse <james.morse@arm.com>
>
>Co-developed-by: is going _in conjunction with_ SoB tag which is missing
>here.
This tag was added as per instruction from Rafael.
I was told that I cannot add SoB tag for others unless specifically given.
Probably I will leave it with Rafael/James to help on this SoB tag
as Rafael was ok to merge this patch.
>
>> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
>
>--
>With Best Regards,
>Andy Shevchenko
>
Thanks,
Shiju