From: Dan Carpenter <dan.carpenter@linaro.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
Ira Weiny <ira.weiny@intel.com>,
linux-acpi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ACPI: APEI: EINJ: Fix check and iounmap of uninitialized pointer p
Date: Wed, 25 Jun 2025 14:50:50 +0300 [thread overview]
Message-ID: <ba07c097-80e2-45e2-b579-fe270c04fabc@suswa.mountain> (raw)
In-Reply-To: <31b6548f-8ff7-4bc5-8a2c-78a5a9d5eb40@suswa.mountain>
On Wed, Jun 25, 2025 at 12:31:10AM +0300, Dan Carpenter wrote:
> On Tue, Jun 24, 2025 at 09:29:37PM +0100, Colin Ian King wrote:
> > In the case where a request_mem_region call fails and pointer r is null
> > the error exit path via label 'out' will check for a non-null pointer
> > p and try to iounmap it. However, pointer p has not been assigned a
> > value at this point, so it may potentially contain any garbage value.
> > Fix this by ensuring pointer p is initialized to NULL.
> >
> > Fixes: 1a35c88302a3 ("ACPI: APEI: EINJ: Fix kernel test sparse warnings")
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > ---
>
> Good catch. Apparently this isn't in my allyesconfig. It's weird the
> zero day bot didn't catch this either.
Never mind. This is definitely in my allyesconfig.
regards,
dan carpenter
next prev parent reply other threads:[~2025-06-25 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 20:29 [PATCH][next] ACPI: APEI: EINJ: Fix check and iounmap of uninitialized pointer p Colin Ian King
2025-06-24 21:31 ` Dan Carpenter
2025-06-25 11:50 ` Dan Carpenter [this message]
2025-06-25 21:40 ` Ira Weiny
2025-06-25 21:43 ` Colin King (gmail)
2025-06-26 14:29 ` Ira Weiny
2025-06-26 18:53 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba07c097-80e2-45e2-b579-fe270c04fabc@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=bp@alien8.de \
--cc=colin.i.king@gmail.com \
--cc=ira.weiny@intel.com \
--cc=james.morse@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox