public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Joao Martins <joao.m.martins@oracle.com>, linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	Robert Moore <robert.moore@intel.com>,
	Erik Schmauss <erik.schmauss@intel.com>,
	xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org,
	devel@acpica.org
Subject: Re: [PATCH v3] xen/acpi: upload _PSD info for non Dom0 CPUs too
Date: Thu, 15 Mar 2018 11:45:01 -0400	[thread overview]
Message-ID: <bbf536dc-3c3d-8a25-47e8-7fd52850835d@oracle.com> (raw)
In-Reply-To: <20180315142205.15839-1-joao.m.martins@oracle.com>

On 03/15/2018 10:22 AM, Joao Martins wrote:
> All uploaded PM data from non-dom0 CPUs takes the info from vCPU 0 and
> changing only the acpi_id. For processors which P-state coordination type
> is HW_ALL (0xFD) it is OK to upload bogus P-state dependency information
> (_PSD), because Xen will ignore any cpufreq domains created for past CPUs.
>
> Albeit for platforms which expose coordination types as SW_ANY or SW_ALL,
> this will have some unintended side effects. Effectively, it will look at
> the P-state domain existence and *if it already exists* it will skip the
> acpi-cpufreq initialization and thus inherit the policy from the first CPU
> in the cpufreq domain. This will finally lead to the original cpu not
> changing target freq to P0 other than the first in the domain. Which will
> make turbo boost not getting enabled (e.g. for 'performance' governor) for
> all cpus.
>
> This patch fixes that, by also evaluating _PSD when we enumerate all ACPI
> processors and thus always uploading the correct info to Xen. We export
> acpi_processor_get_psd() for that this purpose, but change signature
> to not assume an existent of acpi_processor given that ACPI isn't creating
> an acpi_processor for non-dom0 CPUs.
>
> Signed-off-by: Joao Martins <joao.m.martins@oracle.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

  reply	other threads:[~2018-03-15 15:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 14:22 [PATCH v3] xen/acpi: upload _PSD info for non Dom0 CPUs too Joao Martins
2018-03-15 15:45 ` Boris Ostrovsky [this message]
2018-03-16 13:57   ` Joao Martins
2018-03-20  9:41     ` Rafael J. Wysocki
2018-03-20 11:07       ` Joao Martins
2018-03-20 12:56       ` Boris Ostrovsky
2018-03-21 21:15 ` Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbf536dc-3c3d-8a25-47e8-7fd52850835d@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=devel@acpica.org \
    --cc=erik.schmauss@intel.com \
    --cc=jgross@suse.com \
    --cc=joao.m.martins@oracle.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=robert.moore@intel.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox