From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Mario Limonciello <superm1@kernel.org>
Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
"Luke D . Jones" <luke@ljones.dev>,
Mark Pearson <mpearson-lenovo@squebb.ca>,
"open list:AMD PMF DRIVER" <platform-driver-x86@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
"Derek J . Clark" <derekjohn.clark@gmail.com>,
Antheas Kapenekakis <lkml@antheas.dev>,
me@kylegospodneti.ch, Denis Benato <benato.denis96@gmail.com>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH 0/3] Add support for hidden choices to platform_profile
Date: Tue, 4 Mar 2025 18:22:36 +0200 (EET) [thread overview]
Message-ID: <bda43bf4-1d45-d1bf-8d5c-f27727ebc80e@linux.intel.com> (raw)
In-Reply-To: <20250228170155.2623386-1-superm1@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]
On Fri, 28 Feb 2025, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> When two drivers provide platform profile handlers but use different
> strings to mean (essentially) the same thing the legacy interface won't
> export them because it only shows profiles common to multiple drivers.
>
> This causes an unexpected behavior to people who have upgraded from an
> earlier kernel because if multiple drivers have bound platform profile
> handlers they might not be able to access profiles they were expecting.
>
> Introduce a concept of a "hidden choice" that drivers can register and
> the platform profile handler code will utilize when using the legacy
> interface.
>
> There have been some other attempts at solving this issue in other ways.
> This serves as an alternative to those attempts.
>
> Link: https://lore.kernel.org/platform-driver-x86/e64b771e-3255-42ad-9257-5b8fc6c24ac9@gmx.de/T/#t
> Link: https://lore.kernel.org/platform-driver-x86/CAGwozwF-WVEgiAbWbRCiUaXf=BVa3KqmMJfs06trdMQHpTGmjQ@mail.gmail.com/T/#m2f3929e2d4f73cc0eedd14738170dad45232fd18
> Cc: Antheas Kapenekakis <lkml@antheas.dev>
> Cc: "Luke D. Jones" <luke@ljones.dev>
>
> Mario Limonciello (3):
> ACPI: platform_profile: Add support for hidden choices
> platform/x86/amd: pmf: Add 'quiet' to hidden choices
> platform/x86/amd: pmf: Add balanced-performance to hidden choices
>
> drivers/acpi/platform_profile.c | 94 +++++++++++++++++++++++-------
> drivers/platform/x86/amd/pmf/sps.c | 11 ++++
> include/linux/platform_profile.h | 3 +
> 3 files changed, 87 insertions(+), 21 deletions(-)
>
>
Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2025-03-04 16:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 17:01 [PATCH 0/3] Add support for hidden choices to platform_profile Mario Limonciello
2025-02-28 17:01 ` [PATCH 1/3] ACPI: platform_profile: Add support for hidden choices Mario Limonciello
2025-02-28 17:15 ` Antheas Kapenekakis
2025-02-28 22:08 ` Kurt Borja
2025-03-01 3:19 ` Mario Limonciello
2025-03-01 11:06 ` Antheas Kapenekakis
2025-03-01 13:52 ` Mario Limonciello
2025-03-01 14:06 ` Antheas Kapenekakis
2025-03-01 16:03 ` Mario Limonciello
2025-03-01 16:15 ` Antheas Kapenekakis
2025-03-02 3:23 ` Mark Pearson
2025-02-28 17:01 ` [PATCH 2/3] platform/x86/amd: pmf: Add 'quiet' to " Mario Limonciello
2025-02-28 17:01 ` [PATCH 3/3] platform/x86/amd: pmf: Add balanced-performance " Mario Limonciello
2025-02-28 19:39 ` [PATCH 0/3] Add support for hidden choices to platform_profile Mark Pearson
2025-02-28 19:44 ` Mario Limonciello
2025-02-28 19:53 ` Antheas Kapenekakis
2025-02-28 19:56 ` Mario Limonciello
2025-02-28 20:03 ` Mark Pearson
2025-02-28 20:38 ` Derek John Clark
2025-03-01 11:09 ` Antheas Kapenekakis
2025-03-01 13:44 ` Mario Limonciello
2025-03-01 13:51 ` Antheas Kapenekakis
2025-03-04 16:22 ` Ilpo Järvinen [this message]
2025-03-04 19:59 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bda43bf4-1d45-d1bf-8d5c-f27727ebc80e@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=benato.denis96@gmail.com \
--cc=derekjohn.clark@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@antheas.dev \
--cc=luke@ljones.dev \
--cc=mario.limonciello@amd.com \
--cc=me@kylegospodneti.ch \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox