From: Jarred White <jarredwhite@linux.microsoft.com>
To: Easwar Hariharan <eahariha@linux.microsoft.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v2] acpi: Use access_width over register_width for system memory accesses
Date: Fri, 12 Jan 2024 06:19:31 -0800 [thread overview]
Message-ID: <bf1a84e0-bf88-41a1-ad0c-4270aaa5d3aa@linux.microsoft.com> (raw)
In-Reply-To: <6e7db718-65ec-4461-bab9-0ee4c96c25eb@linux.microsoft.com>
On 12/22/2023 4:00 PM, Easwar Hariharan wrote:
> >> @@ -784,7 +792,8 @@ int acpi_cppc_processor_probe(struct
> acpi_processor *pr)
> >> goto out_free;
> >> }
> >>
> >> - addr =
> ioremap(gas_t->address, gas_t->bit_width/8);
> >> + access_width =
> ACCESS_WIDTH_TO_BITS(gas_t) / 8;
> >
> > What would happen if the platform firmware incorrectly provided
> > reg->access_witdh == 0?
> >
>
Unfortunately, we have no hardware platform with this configuration to
test with. What is the level of concern here? Were there previous
changes that raised this similar concerns?
Thanks,
Jarred
next prev parent reply other threads:[~2024-01-12 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 0:13 [RESEND PATCH v2] acpi: Use access_width over register_width for system memory accesses Jarred White
2023-12-21 14:12 ` Rafael J. Wysocki
2023-12-23 0:00 ` Easwar Hariharan
2024-01-12 14:19 ` Jarred White [this message]
2024-02-03 0:44 ` Jarred White
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf1a84e0-bf88-41a1-ad0c-4270aaa5d3aa@linux.microsoft.com \
--to=jarredwhite@linux.microsoft.com \
--cc=eahariha@linux.microsoft.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox