From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FBB0C2BA83 for ; Wed, 12 Feb 2020 16:41:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D73CB20724 for ; Wed, 12 Feb 2020 16:41:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727372AbgBLQlt (ORCPT ); Wed, 12 Feb 2020 11:41:49 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:2417 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727361AbgBLQlt (ORCPT ); Wed, 12 Feb 2020 11:41:49 -0500 Received: from LHREML714-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 3E82A7C504FEDD7BB71E; Wed, 12 Feb 2020 16:41:47 +0000 (GMT) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by LHREML714-CAH.china.huawei.com (10.201.108.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Feb 2020 16:41:47 +0000 Received: from [127.0.0.1] (10.202.226.45) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 12 Feb 2020 16:41:46 +0000 Subject: Re: About PPTT find_acpi_cpu_topology_package() To: Jeremy Linton , Sudeep Holla CC: "Guohanjun (Hanjun Guo)" , ACPI Devel Maling List , "liuqi (BA)" , wanghuiqiang References: <7a888a84-d4c5-2b49-05f3-29876d49cae6@huawei.com> <20200212115945.GA36981@bogus> <20200212135551.GB36981@bogus> <1a04ddf8-4903-2986-a94e-c070dc2c2160@huawei.com> <3c15a54a-18ac-265e-c16c-272577b9dead@arm.com> From: John Garry Message-ID: Date: Wed, 12 Feb 2020 16:41:46 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <3c15a54a-18ac-265e-c16c-272577b9dead@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.202.226.45] X-ClientProxiedBy: lhreml720-chm.china.huawei.com (10.201.108.71) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org >> >> How about something like this: >> >> --- a/drivers/acpi/pptt.c >> +++ b/drivers/acpi/pptt.c >> @@ -515,6 +515,8 @@ static int topology_get_acpi_cpu_tag(struct >> acpi_table_header *table, >>    if (level == 0 || cpu_node->flags & ACPI_PPTT_ACPI_PROCESSOR_ID_VALID) >>      return cpu_node->acpi_processor_id; >> +   if (level == PPTT_ABORT_PACKAGE) >> +    pr_warn_once("ACPI Processor ID valid not set for physical >> package node, will use node table offset as substitute for UID\n"); > Hi Jeremy, > To clarify my other email there, since I can't seem to type clearly.. > > Just note that find_acpi_cpu_topology_hetero_id() is also using a > PPTT_ABORT_PACKAGE termination. OK, so I may need to check the flag == ACPI_PPTT_PHYSICAL_PACKAGE also. BTW, Is the value returned by find_acpi_cpu_topology_hetero_id() also exposed to userspace some way? Or any other PPTT offsets? > > >>                  return ACPI_PTR_DIFF(cpu_node, table); >>          } >>          pr_warn_once("PPTT table found, but unable to locate core %d >> (%d)\n", >> I'll validate Sudeep's suggestion to set the Processor ID valid flag and appropriate processor id for the physical package cpu node with an experimental firmware before sending any patch. There seems to be a bit of doubt on your part regarding that. Thanks, John