Linux ACPI
 help / color / mirror / Atom feed
From: Flavio Suligoi <f.suligoi@asem.it>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: RE: How to add the "gpio-line-names" property in a PCI gpio expander
Date: Fri, 6 Nov 2020 16:47:35 +0000	[thread overview]
Message-ID: <c20e82318bbf426c9d9000cac7e7734b@asem.it> (raw)
In-Reply-To: <20201106070432.GQ2495@lahna.fi.intel.com>

Hi Mika and Andy,

> >
> > root@debian:~# lspci -t
> > -[0000:00]-+-00.0
> >            +-02.0
> >            +-0e.0
> >            +-0f.0
> >            +-12.0
> >            +-13.0-[01]----00.0
> >            +-13.1-[02]----00.0
> >            +-13.2-[03]--
> >            +-14.0-[04]----00.0
> >            +-14.1-[05-09]----00.0-[06-09]--+-01.0-[07]----00.0 <-- Exar
> (bus 7, dev 0, funct 0)
> >            |                               +-02.0-[08]----00.0
> >            |                               \-03.0-[09]--
> >            +-15.0
> >            +-16.0
> >            +-16.1
> >            +-19.0
> >            +-19.1
> >            +-19.2
> >            +-1f.0
> >            \-1f.1
> OK, then add the bridge first:
> 
> Scope (_SB.PCI0.RPX) {
>     Device (BRG) { // Bridge
>        Name (_ADR, 0)
> 
>        Device (EXAR) { // Expander
>            Name (_ADR, 0)
>        }
>     }
> 
> Or something like that. RPX is the root port 14.1 and if I read the
> above right both the bridge and the EXAR device have device and function
> 0.

All ok now, I've added the bridge (I had to use the BIOS sources) and
not it works:

Scope (_SB.PCI0.RP02) {

		Device (BRG1) //Bridge
		{
			Name (_ADR, 0x0000)
		
			Device (BRG2) //Bridge
			{
				Name (_ADR, 0x00010000)

				Device (EXAR)
				{
					Name (_ADR, 0x0000)

					Name (_DSD, Package ()
					{
						ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
						Package ()
						{
							Package ()
							{
								"gpio-line-names",
								Package ()
								{
									"exar_0",
									"exar_1",
									"exar_2",
									"exar_3",
									"exar_4",
									"exar_5",
									"exar_6",
									"exar_7"
								} ....
root@debian:~# gpioinfo gpiochip4
gpiochip4 - 16 lines:
	line   0:     "exar_0"       unused   input  active-high 
	line   1:     "exar_1"       unused   input  active-high 
	line   2:     "exar_2"       unused   input  active-high 
	line   3:     "exar_3"       unused   input  active-high 
	line   4:     "exar_4"       unused   input  active-high 
	line   5:     "exar_5"       unused   input  active-high 
	line   6:     "exar_6"       unused   input  active-high 
	line   7:     "exar_7"       unused   input  active-high 
	line   8:      unnamed       unused   input  active-high 
	line   9:      unnamed       unused   input  active-high 
	line  10:      unnamed       unused   input  active-high 
	line  11:      unnamed       unused   input  active-high 
	line  12:      unnamed       unused   input  active-high 
	line  13:      unnamed       unused   input  active-high 
	line  14:      unnamed       unused   input  active-high 
	line  15:      unnamed       unused   input  active-high 
root@debian:~# 

Thanks for your precious help and ideas !!!

Best regards,

Flavio

  reply	other threads:[~2020-11-06 16:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05  9:46 How to add the "gpio-line-names" property in a PCI gpio expander Flavio Suligoi
2020-11-05 11:51 ` Rafael J. Wysocki
2020-11-05 11:59   ` Mika Westerberg
2020-11-05 14:01     ` Flavio Suligoi
2020-11-05 15:20       ` Mika Westerberg
2020-11-05 15:54         ` Flavio Suligoi
2020-11-05 16:09           ` Andy Shevchenko
2020-11-05 16:19             ` Andy Shevchenko
2020-11-05 16:24               ` Flavio Suligoi
2020-11-06  7:04           ` Mika Westerberg
2020-11-06 16:47             ` Flavio Suligoi [this message]
2020-11-06 17:17               ` Andy Shevchenko
2020-11-09  9:05                 ` Flavio Suligoi
2020-11-09 10:34                   ` Andy Shevchenko
2020-11-09 10:35                     ` Flavio Suligoi
2020-11-09 10:37                     ` Andy Shevchenko
2020-11-05 15:56   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c20e82318bbf426c9d9000cac7e7734b@asem.it \
    --to=f.suligoi@asem.it \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox