Re: [PATCH v2 3/3] platform/surface: Add OF support

[Maximilian Luz <luzmaximilian@gmail.com>]

On 8/10/24 3:28 AM, Konrad Dybcio wrote:
> From: Konrad Dybcio <quic_kdybcio@quicinc.com>

[...]

> @@ -299,7 +302,7 @@ static const struct attribute_group ssam_sam_group = {
>   };
>   
>   
> -/* -- ACPI based device setup. ---------------------------------------------- */
> +/* -- Serial device setup. ------------------------------------------------- */

One more :)

[...]

> diff --git a/drivers/platform/surface/surface3_power.c b/drivers/platform/surface/surface3_power.c
> index 4c0f92562a79..7eab6a124712 100644
> --- a/drivers/platform/surface/surface3_power.c
> +++ b/drivers/platform/surface/surface3_power.c
> @@ -478,7 +478,9 @@ static int mshw0011_install_space_handler(struct i2c_client *client)
>   		return -ENOMEM;
>   	}
>   
> -	acpi_dev_clear_dependencies(adev);
> +	if (adev)
> +		acpi_dev_clear_dependencies(adev);
> +
>   	return 0;
>   }
>   
> diff --git a/drivers/platform/surface/surface_acpi_notify.c b/drivers/platform/surface/surface_acpi_notify.c
> index 20f3870915d2..b0d43e639db2 100644
> --- a/drivers/platform/surface/surface_acpi_notify.c
> +++ b/drivers/platform/surface/surface_acpi_notify.c
> @@ -815,7 +815,9 @@ static int san_probe(struct platform_device *pdev)
>   	if (status)
>   		goto err_install_dev;
>   
> -	acpi_dev_clear_dependencies(san);
> +	if (san)
> +		acpi_dev_clear_dependencies(san);
> +
>   	return 0;
>   
>   err_install_dev:

Are these two changes required? Surface 3 power and SAN should AFAIK be
fairly "legacy" and ACPI-only drivers, which I don't expect to be used
on any of the new ARM devices (apart from there probably being other
changes required to make them work with DT).

I think with that addressed, it should be fine. I'll give it a spin
tomorrow and send in my r-b and t-b (assuming everything goes well).

Best regards,
Max