* [PATCH] ACPI: resource: Skip IRQ override on ASUS Vivobook 14 X1404VAP
@ 2025-03-18 16:09 Paul Menzel
2025-03-18 16:18 ` Hans de Goede
2025-03-19 12:50 ` Anton Shyndin
0 siblings, 2 replies; 4+ messages in thread
From: Paul Menzel @ 2025-03-18 16:09 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown
Cc: Paul Menzel, Anton Shyndin, Hans de Goede, All applicable,
linux-acpi, linux-kernel
Like the ASUS Vivobook X1504VAP and Vivobook X1704VAP, the ASUS Vivobook 14
X1404VAP has its keyboard IRQ (1) described as ActiveLow in the DSDT, which
the kernel overrides to EdgeHigh breaking the keyboard.
$ sudo dmidecode
[…]
System Information
Manufacturer: ASUSTeK COMPUTER INC.
Product Name: ASUS Vivobook 14 X1404VAP_X1404VA
[…]
$ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1
IRQ (Level, ActiveLow, Exclusive, )
{1}
Add the X1404VAP to the irq1_level_low_skip_override[] quirk table to fix
this.
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219224
Cc: Anton Shyndin <mrcold.il@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
drivers/acpi/resource.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index b4cd14e7fa76..14c7bac4100b 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -440,6 +440,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
},
},
+ {
+ /* Asus Vivobook X1404VAP */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_BOARD_NAME, "X1404VAP"),
+ },
+ },
{
/* Asus Vivobook X1504VAP */
.matches = {
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ACPI: resource: Skip IRQ override on ASUS Vivobook 14 X1404VAP
2025-03-18 16:09 [PATCH] ACPI: resource: Skip IRQ override on ASUS Vivobook 14 X1404VAP Paul Menzel
@ 2025-03-18 16:18 ` Hans de Goede
2025-03-19 12:50 ` Anton Shyndin
1 sibling, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2025-03-18 16:18 UTC (permalink / raw)
To: Paul Menzel, Rafael J. Wysocki, Len Brown
Cc: Anton Shyndin, All applicable, linux-acpi, linux-kernel
Hi,
On 18-Mar-25 17:09, Paul Menzel wrote:
> Like the ASUS Vivobook X1504VAP and Vivobook X1704VAP, the ASUS Vivobook 14
> X1404VAP has its keyboard IRQ (1) described as ActiveLow in the DSDT, which
> the kernel overrides to EdgeHigh breaking the keyboard.
>
> $ sudo dmidecode
> […]
> System Information
> Manufacturer: ASUSTeK COMPUTER INC.
> Product Name: ASUS Vivobook 14 X1404VAP_X1404VA
> […]
> $ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1
> IRQ (Level, ActiveLow, Exclusive, )
> {1}
>
> Add the X1404VAP to the irq1_level_low_skip_override[] quirk table to fix
> this.
>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219224
> Cc: Anton Shyndin <mrcold.il@gmail.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: All applicable <stable@vger.kernel.org>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/acpi/resource.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index b4cd14e7fa76..14c7bac4100b 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -440,6 +440,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
> DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
> },
> },
> + {
> + /* Asus Vivobook X1404VAP */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_BOARD_NAME, "X1404VAP"),
> + },
> + },
> {
> /* Asus Vivobook X1504VAP */
> .matches = {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ACPI: resource: Skip IRQ override on ASUS Vivobook 14 X1404VAP
2025-03-18 16:09 [PATCH] ACPI: resource: Skip IRQ override on ASUS Vivobook 14 X1404VAP Paul Menzel
2025-03-18 16:18 ` Hans de Goede
@ 2025-03-19 12:50 ` Anton Shyndin
2025-03-27 19:39 ` Rafael J. Wysocki
1 sibling, 1 reply; 4+ messages in thread
From: Anton Shyndin @ 2025-03-19 12:50 UTC (permalink / raw)
To: Paul Menzel
Cc: Rafael J. Wysocki, Len Brown, Hans de Goede, All applicable,
linux-acpi, linux-kernel
Tested-by: Anton Shyndin <mrcold.il@gmail.com>
On Tue, Mar 18, 2025 at 6:09 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Like the ASUS Vivobook X1504VAP and Vivobook X1704VAP, the ASUS Vivobook 14
> X1404VAP has its keyboard IRQ (1) described as ActiveLow in the DSDT, which
> the kernel overrides to EdgeHigh breaking the keyboard.
>
> $ sudo dmidecode
> […]
> System Information
> Manufacturer: ASUSTeK COMPUTER INC.
> Product Name: ASUS Vivobook 14 X1404VAP_X1404VA
> […]
> $ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1
> IRQ (Level, ActiveLow, Exclusive, )
> {1}
>
> Add the X1404VAP to the irq1_level_low_skip_override[] quirk table to fix
> this.
>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219224
> Cc: Anton Shyndin <mrcold.il@gmail.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: All applicable <stable@vger.kernel.org>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> drivers/acpi/resource.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index b4cd14e7fa76..14c7bac4100b 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -440,6 +440,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
> DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
> },
> },
> + {
> + /* Asus Vivobook X1404VAP */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_BOARD_NAME, "X1404VAP"),
> + },
> + },
> {
> /* Asus Vivobook X1504VAP */
> .matches = {
> --
> 2.49.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ACPI: resource: Skip IRQ override on ASUS Vivobook 14 X1404VAP
2025-03-19 12:50 ` Anton Shyndin
@ 2025-03-27 19:39 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2025-03-27 19:39 UTC (permalink / raw)
To: Anton Shyndin, Paul Menzel
Cc: Len Brown, Hans de Goede, All applicable, linux-acpi,
linux-kernel
On Wed, Mar 19, 2025 at 1:50 PM Anton Shyndin <mrcold.il@gmail.com> wrote:
>
> Tested-by: Anton Shyndin <mrcold.il@gmail.com>
>
> On Tue, Mar 18, 2025 at 6:09 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> >
> > Like the ASUS Vivobook X1504VAP and Vivobook X1704VAP, the ASUS Vivobook 14
> > X1404VAP has its keyboard IRQ (1) described as ActiveLow in the DSDT, which
> > the kernel overrides to EdgeHigh breaking the keyboard.
> >
> > $ sudo dmidecode
> > […]
> > System Information
> > Manufacturer: ASUSTeK COMPUTER INC.
> > Product Name: ASUS Vivobook 14 X1404VAP_X1404VA
> > […]
> > $ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1
> > IRQ (Level, ActiveLow, Exclusive, )
> > {1}
> >
> > Add the X1404VAP to the irq1_level_low_skip_override[] quirk table to fix
> > this.
> >
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219224
> > Cc: Anton Shyndin <mrcold.il@gmail.com>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: All applicable <stable@vger.kernel.org>
> > Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> > ---
> > drivers/acpi/resource.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> > index b4cd14e7fa76..14c7bac4100b 100644
> > --- a/drivers/acpi/resource.c
> > +++ b/drivers/acpi/resource.c
> > @@ -440,6 +440,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
> > DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
> > },
> > },
> > + {
> > + /* Asus Vivobook X1404VAP */
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_BOARD_NAME, "X1404VAP"),
> > + },
> > + },
> > {
> > /* Asus Vivobook X1504VAP */
> > .matches = {
> > --
Applied as 6.15-rc material, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-27 19:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-18 16:09 [PATCH] ACPI: resource: Skip IRQ override on ASUS Vivobook 14 X1404VAP Paul Menzel
2025-03-18 16:18 ` Hans de Goede
2025-03-19 12:50 ` Anton Shyndin
2025-03-27 19:39 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox