Re: [PATCH] thermal: consistently use int for temperatures

From: Peter Feuerer <peter@piie.net>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "Lukasz Majewski" <l.majewski@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	"Heiko Stuebner" <heiko@sntech.de>,
	linux-pm@vger.kernel.org, lm-sensors@lm-sensors.org,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	"Eduardo Valentin" <edubezval@gmail.com>,
	linux-acpi@vger.kernel.org,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Guenter Roeck" <linux@roeck-us.net>,
	linux-arm-kernel@lists.infradead.org,
	"Darren Hart" <dvhart@infradead.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	linux-omap@vger.kernel.org,
	"Maxime Ripard" <maxime.ripard@free-electrons.com>,
	"Jean Delvare" <jdelvare@suse.de>
Subject: Re: [PATCH] thermal: consistently use int for temperatures
Date: Wed, 08 Jul 2015 10:11:24 +0200	[thread overview]
Message-ID: <cone.1436343084.787318.20214.1000@mups> (raw)
In-Reply-To: 1436167189-29835-1-git-send-email-s.hauer@pengutronix.de

Sascha Hauer writes:

> The thermal code uses int, long and unsigned long for temperatures
> in different places.
> 
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0°C. This will probably
> immediately shut the machine down due to overtemperature if started below
> 0°C.
> 
> 'long' is 64bit on several architectures. This is not needed since INT_MAX °mC
> is above the melting point of all known materials.
> 
> Consistently use a plain 'int' for temperatures throughout the thermal code and
> the drivers. This only changes the places in the drivers where the temperature
> is passed around as pointer, when drivers internally use another type this is
> not changed.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Peter Feuerer <peter@piie.net>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: linux-acpi@vger.kernel.org
> Cc: platform-driver-x86@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: lm-sensors@lm-sensors.org
> ---

[...]

For:

>  drivers/platform/x86/acerhdf.c                     |  9 ++++----
>  drivers/thermal/gov_bang_bang.c                    |  5 ++--

Reviewed-by: Peter Feuerer <peter@piie.net>

[...]

-- 
--peter;

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel