public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Linda Knippers <linda.knippers@hpe.com>
To: dan.j.williams@intel.com, vishal.l.verma@intel.com
Cc: linux-nvdimm@lists.01.org, linux-acpi@vger.kernel.org,
	jmoyer@redhat.com, toshi.kani@hpe.com, elliott@hpe.com,
	rafael.j.wysocki@intel.com
Subject: [PATCH 0/3] fix NVDIMM hotplug changes
Date: Fri, 20 Nov 2015 19:05:46 -0500	[thread overview]
Message-ID: <cover.1448045168.git.linda.knippers@hpe.com> (raw)

Since commit 209851649dc4f7900a6bfe1de5e2640ab2c7d931 
("acpi: nfit: Add support for hot-add"), we no longer see 
NVDIMM devices on our NVDIMM-N systems.  The NFIT/_FIT processing 
at initialization gets a table from _FIT but thinks it is 
malformed and exits, leaving us with no NFIT at all.

This series fixes the problem caused by a difference in ACPI
spec interpretation regarding the layout of the _FIT vs. NFIT
tables.  In addition to changing the code, we are proposing
wording changes to the ACPI spec.

While testing the notify code path, I discovered that the 
way the old and new tables were compared didn't take into account
that there is some variation in table length.  I also determined
that the check for whether the NFIT merge was successful was
backwards.

I couldn't find a generic way to invoke the notify function
so my testing was done with a change to the the revision_show()
function that calls acpi_nfit_notify() any time the sysfs
nfit/revision file is read.  That change is not included here.

These patches were tested on a system with NVDIMM-N hardware
so changes related to NFIT tables not provided on a NVDIMM-N
system have only been compile-tested.  

Linda Knippers (3):
  nfit: Account for table size length variation
  nfit: Fix the check for a successful NFIT merge
  nfit: Adjust for different _FIT and NFIT headers

 drivers/acpi/nfit.c | 83 +++++++++++++++++++++++++++++++++++++++++------------
 drivers/acpi/nfit.h |  3 +-
 2 files changed, 67 insertions(+), 19 deletions(-)

-- 
1.8.3.1


             reply	other threads:[~2015-11-21  0:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-21  0:05 Linda Knippers [this message]
2015-11-21  0:05 ` [PATCH 1/3] nfit: Account for table size length variation Linda Knippers
2015-11-23 23:21   ` Verma, Vishal L
2015-11-24 16:24     ` Linda Knippers
2015-11-24 16:31       ` Dan Williams
2015-11-24 17:47       ` Verma, Vishal L
2015-11-21  0:05 ` [PATCH 2/3] nfit: Fix the check for a successful NFIT merge Linda Knippers
2015-11-21  0:05 ` [PATCH 3/3] nfit: Adjust for different _FIT and NFIT headers Linda Knippers
2015-11-23 23:26   ` Verma, Vishal L
2015-11-24 16:31     ` Linda Knippers
2015-11-24 17:52       ` Verma, Vishal L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1448045168.git.linda.knippers@hpe.com \
    --to=linda.knippers@hpe.com \
    --cc=dan.j.williams@intel.com \
    --cc=elliott@hpe.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=toshi.kani@hpe.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox