* [PATCH 1/7] ACPICA: Update an info message during table load phase.
2016-10-17 19:01 [PATCH 0/7] ACPICA: 20160930 Release Lv Zheng
@ 2016-10-17 19:02 ` Lv Zheng
2016-10-17 19:02 ` [PATCH 2/7] ACPICA: MacOSX: Fix anonymous semaphore implementation Lv Zheng
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Lv Zheng @ 2016-10-17 19:02 UTC (permalink / raw)
To: Rafael J . Wysocki, Rafael J . Wysocki, Robert Moore, Len Brown,
Lv Zheng, David E . Box
Cc: linux-acpi
From: Bob Moore <robert.moore@intel.com>
ACPICA commit 1d435008fd9ea34768df8862de9cb6fff69650f6
Only emit an extra newline for acpiexec.
Link: https://github.com/acpica/acpica/commit/1d435008
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
drivers/acpi/acpica/tbxfload.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c
index 5569f63..2599e831 100644
--- a/drivers/acpi/acpica/tbxfload.c
+++ b/drivers/acpi/acpica/tbxfload.c
@@ -239,7 +239,7 @@ acpi_status acpi_tb_load_namespace(void)
}
if (!tables_failed) {
- ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded\n", tables_loaded));
+ ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded", tables_loaded));
} else {
ACPI_ERROR((AE_INFO,
"%u table load failures, %u successful",
@@ -250,6 +250,10 @@ acpi_status acpi_tb_load_namespace(void)
status = AE_CTRL_TERMINATE;
}
+#ifdef ACPI_APPLICATION
+ ACPI_DEBUG_PRINT_RAW((ACPI_DB_INIT, "\n"));
+#endif
+
unlock_and_exit:
(void)acpi_ut_release_mutex(ACPI_MTX_TABLES);
return_ACPI_STATUS(status);
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/7] ACPICA: MacOSX: Fix anonymous semaphore implementation
2016-10-17 19:01 [PATCH 0/7] ACPICA: 20160930 Release Lv Zheng
2016-10-17 19:02 ` [PATCH 1/7] ACPICA: Update an info message during table load phase Lv Zheng
@ 2016-10-17 19:02 ` Lv Zheng
2016-10-17 19:03 ` [PATCH 3/7] ACPICA: MacOSX: Fix wrong sem_destroy definition Lv Zheng
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Lv Zheng @ 2016-10-17 19:02 UTC (permalink / raw)
To: Rafael J . Wysocki, Rafael J . Wysocki, Robert Moore, Len Brown,
Lv Zheng, David E . Box
Cc: linux-acpi
ACPICA commit 01eb9a58f4cf6300a0feb838a02bc4b1895c76e8
ACPICA commit de5b9c0ef1ccb264cbe57c88f6dd3fbf8229f907
The following build errors can be seen for MacOSX builds:
.../osunixxf.c:829:42: error: 'tmpnam' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of tmpnam(3), it is highly recommended that you use mkstemp(3) instead. [-Werror,-Wdeprecated-declarations]
Using of temporal file name functions can easily result in bus errors on
MacOSX. This patch implements anonymous semaphore using an automatic
increasing number. Lv Zheng.
Linux is not affected by this change.
Link: https://github.com/acpica/acpica/commit/01eb9a58
Link: https://github.com/acpica/acpica/commit/de5b9c0e
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
---
tools/power/acpi/os_specific/service_layers/osunixxf.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/power/acpi/os_specific/service_layers/osunixxf.c b/tools/power/acpi/os_specific/service_layers/osunixxf.c
index 8d8003c..8f5ded8 100644
--- a/tools/power/acpi/os_specific/service_layers/osunixxf.c
+++ b/tools/power/acpi/os_specific/service_layers/osunixxf.c
@@ -646,8 +646,12 @@ acpi_os_create_semaphore(u32 max_units,
}
#ifdef __APPLE__
{
- char *semaphore_name = tmpnam(NULL);
+ static int semaphore_count = 0;
+ char semaphore_name[32];
+ snprintf(semaphore_name, sizeof(semaphore_name), "acpi_sem_%d",
+ semaphore_count++);
+ printf("%s\n", semaphore_name);
sem =
sem_open(semaphore_name, O_EXCL | O_CREAT, 0755,
initial_units);
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/7] ACPICA: MacOSX: Fix wrong sem_destroy definition
2016-10-17 19:01 [PATCH 0/7] ACPICA: 20160930 Release Lv Zheng
2016-10-17 19:02 ` [PATCH 1/7] ACPICA: Update an info message during table load phase Lv Zheng
2016-10-17 19:02 ` [PATCH 2/7] ACPICA: MacOSX: Fix anonymous semaphore implementation Lv Zheng
@ 2016-10-17 19:03 ` Lv Zheng
2016-10-17 19:03 ` [PATCH 4/7] ACPICA: Increase loop limit for AE_AML_INFINITE_LOOP exception Lv Zheng
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Lv Zheng @ 2016-10-17 19:03 UTC (permalink / raw)
To: Rafael J . Wysocki, Rafael J . Wysocki, Robert Moore, Len Brown,
Lv Zheng, David E . Box
Cc: linux-acpi
ACPICA commit bbcb58f7875381d5c7f3d614bad3bc628a3f5cc6
The following build errors can be seen for MacOSX builds:
.../osunixxf.c:882:9: error: 'sem_close' is deprecated [-Werror,-Wdeprecated-declarations]
.../acmacosx.h:122:29: note: expanded from macro 'sem_destroy'
#define sem_destroy sem_close
sem_destroy() issue is caused by the wrong order of the following lines:
#define #sem_destroy sem_close
#include <semaphore.h>
This patch fixes it by removing the buggy re-definitiion. Lv Zheng.
Linux is not affected by this change.
Link: https://github.com/acpica/acpica/commit/bbcb58f7
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
---
tools/power/acpi/os_specific/service_layers/osunixxf.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/power/acpi/os_specific/service_layers/osunixxf.c b/tools/power/acpi/os_specific/service_layers/osunixxf.c
index 8f5ded8..10648aa 100644
--- a/tools/power/acpi/os_specific/service_layers/osunixxf.c
+++ b/tools/power/acpi/os_specific/service_layers/osunixxf.c
@@ -696,10 +696,15 @@ acpi_status acpi_os_delete_semaphore(acpi_handle handle)
if (!sem) {
return (AE_BAD_PARAMETER);
}
-
+#ifdef __APPLE__
+ if (sem_close(sem) == -1) {
+ return (AE_BAD_PARAMETER);
+ }
+#else
if (sem_destroy(sem) == -1) {
return (AE_BAD_PARAMETER);
}
+#endif
return (AE_OK);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 4/7] ACPICA: Increase loop limit for AE_AML_INFINITE_LOOP exception
2016-10-17 19:01 [PATCH 0/7] ACPICA: 20160930 Release Lv Zheng
` (2 preceding siblings ...)
2016-10-17 19:03 ` [PATCH 3/7] ACPICA: MacOSX: Fix wrong sem_destroy definition Lv Zheng
@ 2016-10-17 19:03 ` Lv Zheng
2016-10-17 19:03 ` [PATCH 5/7] ACPICA: Disassembler: Fix for Divide() support, new support for test suite Lv Zheng
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Lv Zheng @ 2016-10-17 19:03 UTC (permalink / raw)
To: Rafael J . Wysocki, Rafael J . Wysocki, Robert Moore, Len Brown,
Lv Zheng, David E . Box
Cc: linux-acpi
From: Bob Moore <robert.moore@intel.com>
ACPICA commit 9f83b34cb172549c20f18663bc7460fb4145a75b
increase loop limit to accomodate faster processors. From 64k loops max
to 1 million.
Link: https://github.com/acpica/acpica/commit/9f83b34c
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
drivers/acpi/acpica/acglobal.h | 2 +-
include/acpi/acconfig.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpica/acglobal.h b/drivers/acpi/acpica/acglobal.h
index 750fa82..17f7bb8 100644
--- a/drivers/acpi/acpica/acglobal.h
+++ b/drivers/acpi/acpica/acglobal.h
@@ -242,7 +242,7 @@ ACPI_GLOBAL(struct acpi_thread_state *, acpi_gbl_current_walk_list);
/* Maximum number of While() loop iterations before forced abort */
-ACPI_GLOBAL(u16, acpi_gbl_max_loop_iterations);
+ACPI_GLOBAL(u32, acpi_gbl_max_loop_iterations);
/* Control method single step flag */
diff --git a/include/acpi/acconfig.h b/include/acpi/acconfig.h
index 12c2882..d25da93 100644
--- a/include/acpi/acconfig.h
+++ b/include/acpi/acconfig.h
@@ -146,7 +146,7 @@
/* Maximum number of While() loops before abort */
-#define ACPI_MAX_LOOP_COUNT 0xFFFF
+#define ACPI_MAX_LOOP_COUNT 0x000FFFFF
/******************************************************************************
*
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/7] ACPICA: Disassembler: Fix for Divide() support, new support for test suite
2016-10-17 19:01 [PATCH 0/7] ACPICA: 20160930 Release Lv Zheng
` (3 preceding siblings ...)
2016-10-17 19:03 ` [PATCH 4/7] ACPICA: Increase loop limit for AE_AML_INFINITE_LOOP exception Lv Zheng
@ 2016-10-17 19:03 ` Lv Zheng
2016-10-17 19:03 ` [PATCH 6/7] ACPICA: Move acpi_gbl_max_loop_iterations to the public globals file Lv Zheng
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Lv Zheng @ 2016-10-17 19:03 UTC (permalink / raw)
To: Rafael J . Wysocki, Rafael J . Wysocki, Robert Moore, Len Brown,
Lv Zheng, David E . Box
Cc: linux-acpi
From: Bob Moore <robert.moore@intel.com>
ACPICA commit 4b367408659af08fd44839866ec301285284e6f4
Fixes a problem with complex expressions where an illegal mix
of legacy ASL and ASL+ could be emitted.
Adds new support for ASLTS that disables some disassembler
optimizations could be changed during a conversion to ASL+.
These expressions are now emitted in legacy ASL instead
of ASL+.
Link: https://github.com/acpica/acpica/commit/4b367408
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
drivers/acpi/acpica/acglobal.h | 1 +
drivers/acpi/acpica/aclocal.h | 19 ++++++++++---------
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/acpi/acpica/acglobal.h b/drivers/acpi/acpica/acglobal.h
index 17f7bb8..b549e6d 100644
--- a/drivers/acpi/acpica/acglobal.h
+++ b/drivers/acpi/acpica/acglobal.h
@@ -318,6 +318,7 @@ ACPI_INIT_GLOBAL(u8, acpi_gbl_cstyle_disassembly, TRUE);
ACPI_INIT_GLOBAL(u8, acpi_gbl_force_aml_disassembly, FALSE);
ACPI_INIT_GLOBAL(u8, acpi_gbl_dm_opt_verbose, TRUE);
ACPI_INIT_GLOBAL(u8, acpi_gbl_dm_emit_external_opcodes, FALSE);
+ACPI_INIT_GLOBAL(u8, acpi_gbl_do_disassembler_optimizations, TRUE);
ACPI_GLOBAL(u8, acpi_gbl_dm_opt_disasm);
ACPI_GLOBAL(u8, acpi_gbl_dm_opt_listing);
diff --git a/drivers/acpi/acpica/aclocal.h b/drivers/acpi/acpica/aclocal.h
index dff1207..7926600 100644
--- a/drivers/acpi/acpica/aclocal.h
+++ b/drivers/acpi/acpica/aclocal.h
@@ -765,7 +765,7 @@ union acpi_parse_value {
union acpi_parse_value value; /* Value or args associated with the opcode */\
u8 arg_list_length; /* Number of elements in the arg list */\
ACPI_DISASM_ONLY_MEMBERS (\
- u8 disasm_flags; /* Used during AML disassembly */\
+ u16 disasm_flags; /* Used during AML disassembly */\
u8 disasm_opcode; /* Subtype used for disassembly */\
char *operator_symbol;/* Used for C-style operator name strings */\
char aml_op_name[16]) /* Op name (debug only) */
@@ -868,14 +868,15 @@ struct acpi_parse_state {
/* Parse object disasm_flags */
-#define ACPI_PARSEOP_IGNORE 0x01
-#define ACPI_PARSEOP_PARAMETER_LIST 0x02
-#define ACPI_PARSEOP_EMPTY_TERMLIST 0x04
-#define ACPI_PARSEOP_PREDEFINED_CHECKED 0x08
-#define ACPI_PARSEOP_CLOSING_PAREN 0x10
-#define ACPI_PARSEOP_COMPOUND_ASSIGNMENT 0x20
-#define ACPI_PARSEOP_ASSIGNMENT 0x40
-#define ACPI_PARSEOP_ELSEIF 0x80
+#define ACPI_PARSEOP_IGNORE 0x0001
+#define ACPI_PARSEOP_PARAMETER_LIST 0x0002
+#define ACPI_PARSEOP_EMPTY_TERMLIST 0x0004
+#define ACPI_PARSEOP_PREDEFINED_CHECKED 0x0008
+#define ACPI_PARSEOP_CLOSING_PAREN 0x0010
+#define ACPI_PARSEOP_COMPOUND_ASSIGNMENT 0x0020
+#define ACPI_PARSEOP_ASSIGNMENT 0x0040
+#define ACPI_PARSEOP_ELSEIF 0x0080
+#define ACPI_PARSEOP_LEGACY_ASL_ONLY 0x0100
/*****************************************************************************
*
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 6/7] ACPICA: Move acpi_gbl_max_loop_iterations to the public globals file
2016-10-17 19:01 [PATCH 0/7] ACPICA: 20160930 Release Lv Zheng
` (4 preceding siblings ...)
2016-10-17 19:03 ` [PATCH 5/7] ACPICA: Disassembler: Fix for Divide() support, new support for test suite Lv Zheng
@ 2016-10-17 19:03 ` Lv Zheng
2016-10-17 19:04 ` [PATCH 7/7] ACPICA: Update version to 20160930 Lv Zheng
2016-11-14 0:14 ` [PATCH 0/7] ACPICA: 20160930 Release Rafael J. Wysocki
7 siblings, 0 replies; 9+ messages in thread
From: Lv Zheng @ 2016-10-17 19:03 UTC (permalink / raw)
To: Rafael J . Wysocki, Rafael J . Wysocki, Robert Moore, Len Brown,
Lv Zheng, David E . Box
Cc: linux-acpi
From: Bob Moore <robert.moore@intel.com>
ACPICA commit eb8b2194200867dec9ba38e5ab98b5b8ef262945
Moved to acpixf.h with the rest of the configuration globals.
Link: https://github.com/acpica/acpica/commit/eb8b2194
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
drivers/acpi/acpica/acglobal.h | 4 ----
include/acpi/acpixf.h | 7 +++++++
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/acpica/acglobal.h b/drivers/acpi/acpica/acglobal.h
index b549e6d..edbb42e 100644
--- a/drivers/acpi/acpica/acglobal.h
+++ b/drivers/acpi/acpica/acglobal.h
@@ -240,10 +240,6 @@ ACPI_INIT_GLOBAL(u32, acpi_gbl_nesting_level, 0);
ACPI_GLOBAL(struct acpi_thread_state *, acpi_gbl_current_walk_list);
-/* Maximum number of While() loop iterations before forced abort */
-
-ACPI_GLOBAL(u32, acpi_gbl_max_loop_iterations);
-
/* Control method single step flag */
ACPI_GLOBAL(u8, acpi_gbl_cm_single_step);
diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
index c7b3a13..07ab21e 100644
--- a/include/acpi/acpixf.h
+++ b/include/acpi/acpixf.h
@@ -259,6 +259,13 @@ ACPI_INIT_GLOBAL(u8, acpi_gbl_osi_data, 0);
ACPI_INIT_GLOBAL(u8, acpi_gbl_reduced_hardware, FALSE);
/*
+ * Maximum number of While() loop iterations before forced method abort.
+ * This mechanism is intended to prevent infinite loops during interpreter
+ * execution within a host kernel.
+ */
+ACPI_INIT_GLOBAL(u32, acpi_gbl_max_loop_iterations, ACPI_MAX_LOOP_COUNT);
+
+/*
* This mechanism is used to trace a specified AML method. The method is
* traced each time it is executed.
*/
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 7/7] ACPICA: Update version to 20160930
2016-10-17 19:01 [PATCH 0/7] ACPICA: 20160930 Release Lv Zheng
` (5 preceding siblings ...)
2016-10-17 19:03 ` [PATCH 6/7] ACPICA: Move acpi_gbl_max_loop_iterations to the public globals file Lv Zheng
@ 2016-10-17 19:04 ` Lv Zheng
2016-11-14 0:14 ` [PATCH 0/7] ACPICA: 20160930 Release Rafael J. Wysocki
7 siblings, 0 replies; 9+ messages in thread
From: Lv Zheng @ 2016-10-17 19:04 UTC (permalink / raw)
To: Rafael J . Wysocki, Rafael J . Wysocki, Robert Moore, Len Brown,
Lv Zheng, David E . Box
Cc: linux-acpi
From: Bob Moore <robert.moore@intel.com>
ACPICA commit cb8dfc8157ae54aadb1beb31d996db9327438183
Version 20160930.
Link: https://github.com/acpica/acpica/commit/cb8dfc81
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
include/acpi/acpixf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
index 07ab21e..5c7356a 100644
--- a/include/acpi/acpixf.h
+++ b/include/acpi/acpixf.h
@@ -46,7 +46,7 @@
/* Current ACPICA subsystem version in YYYYMMDD format */
-#define ACPI_CA_VERSION 0x20160831
+#define ACPI_CA_VERSION 0x20160930
#include <acpi/acconfig.h>
#include <acpi/actypes.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 0/7] ACPICA: 20160930 Release
2016-10-17 19:01 [PATCH 0/7] ACPICA: 20160930 Release Lv Zheng
` (6 preceding siblings ...)
2016-10-17 19:04 ` [PATCH 7/7] ACPICA: Update version to 20160930 Lv Zheng
@ 2016-11-14 0:14 ` Rafael J. Wysocki
7 siblings, 0 replies; 9+ messages in thread
From: Rafael J. Wysocki @ 2016-11-14 0:14 UTC (permalink / raw)
To: Lv Zheng
Cc: Rafael J . Wysocki, Robert Moore, Len Brown, Lv Zheng,
David E . Box, linux-acpi
On Tuesday, October 18, 2016 03:01:48 AM Lv Zheng wrote:
> The 20160930 ACPICA kernel-resident subsystem updates are linuxized based
> on the linux-pm/linux-next branch.
>
> The patchset has passed the following build/boot tests.
> Build tests are performed as follows:
> 1. i386 + allyes
> 2. i386 + allno
> 3. i386 + default + ACPI_DEBUGGER=y
> 4. i386 + default + ACPI_DEBUGGER=n + ACPI_DEBUG=y
> 5. i386 + default + ACPI_DEBUG=n + ACPI=y
> 6. i386 + default + ACPI=n
> 7. x86_64 + allyes
> 8. x86_64 + allno
> 9. x86_64 + default + ACPI_DEBUGGER=y
> 10.x86_64 + default + ACPI_DEBUGGER=n + ACPI_DEBUG=y
> 11.x86_64 + default + ACPI_DEBUG=n + ACPI=y
> 12.x86_64 + default + ACPI=n
> Boot tests are performed as follows:
> 1. x86_64 + default + ACPI_DEBUGGER=y
> Where:
> 1. i386: machine named as "Dell Inspiron Mini 1010"
> 2. x86_64: machine named as "Microsoft Surface Pro 3"
> 3. default: kernel configuration with following items enabled:
> All hardware drivers related to the machines of i386/x86_64
> All "drivers/acpi" configurations
> All "drivers/platform" drivers
> All other drivers that link the APIs provided by ACPICA subsystem
>
> The divergences checking result:
> Before applying (20160831 Release):
> 508 lines
> After applying (20160930 Release):
> 508 lines
>
> Bob Moore (5):
> ACPICA: Update an info message during table load phase.
> ACPICA: Increase loop limit for AE_AML_INFINITE_LOOP exception
> ACPICA: Disassembler: Fix for Divide() support, new support for test
> suite
> ACPICA: Move acpi_gbl_max_loop_iterations to the public globals file
> ACPICA: Update version to 20160930
>
> Lv Zheng (2):
> ACPICA: MacOSX: Fix anonymous semaphore implementation
> ACPICA: MacOSX: Fix wrong sem_destroy definition
>
> drivers/acpi/acpica/acglobal.h | 5 +----
> drivers/acpi/acpica/aclocal.h | 19 ++++++++++---------
> drivers/acpi/acpica/tbxfload.c | 6 +++++-
> include/acpi/acconfig.h | 2 +-
> include/acpi/acpixf.h | 9 ++++++++-
> .../power/acpi/os_specific/service_layers/osunixxf.c | 13 +++++++++++--
> 6 files changed, 36 insertions(+), 18 deletions(-)
Whole series applied.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 9+ messages in thread