From: Lv Zheng <lv.zheng@intel.com>
To: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>,
Robert Moore <robert.moore@intel.com>,
Lv Zheng <lv.zheng@intel.com>,
"David E . Box" <david.e.box@intel.com>
Cc: Lv Zheng <zetalog@gmail.com>,
linux-acpi@vger.kernel.org, devel@acpica.org,
Hans de Goede <hdegoede@redhat.com>
Subject: [RFC PATCH v2 0/5] ACPICA: Tables: Add deferred verification support
Date: Tue, 16 May 2017 15:13:08 +0800 [thread overview]
Message-ID: <cover.1494916766.git.lv.zheng@intel.com> (raw)
In-Reply-To: <20170227093432.3308-1-hdegoede@redhat.com>
On linux, we can not verify ACPI tables before installing them into the
global table list in early stage due to the number of slot limitations for
early ioremap. This leaves a problem that we cannot detect duplicated
tables in early stage, causing unwanted error messages seen when the
duplicated tables are failed to be loaded [link #1].
This patchset as ACPICA PR [link #2] adds support to verify tables in
acpi_reallocate_root_tables() which is invoked after installing tables in
early stage, being ready for late ioremap and beofre loading table in late
stage. If duplicated tables are detected, acpi_reallocate_root_tables()
stops installing them to the final reallocated global table list.
In v1 patchset [link #3], problems can be seen for dynamic loading tables
which are allocated as virtuall allocated tables. Such tables are
incremented in the global table list as the sanity check done in install
step only compares the table addresses while the virtual allocated
addresses are not stable.
In v2 patchset, we follow original design discussion made in ACPICA devel
mailing list, implements deferred table verification so that duplicate
tables are still can be detected in install step rather than in load step.
Also we removed table signature check according to verified windows
behavior [link #4] and reported issues [link #5].
Link: http://www.spinics.net/lists/linux-acpi/msg72215.html [#1]
Link: https://github.com//acpica/acpica/pull/265 [#2]
Link: http://www.spinics.net/lists/linux-acpi/msg72589.html [#3]
Link: https://github.com//acpica/acpica/pull/121 [#4]
https://bugzilla.kernel.org/show_bug.cgi?id=118601 [#5]
Lv Zheng (5):
ACPICA: Tables: Cleanup table handler invokers
ACPICA: Tables: Do not validate signature for dynamic table load
ACPICA: Tables: Change table duplication check to be related to
acpi_gbl_verify_table_checksum
ACPICA: Tables: Combine checksum/duplication verification together
ACPICA: Tables: Add deferred table verification support
drivers/acpi/acpica/actables.h | 5 +-
drivers/acpi/acpica/tbdata.c | 222 ++++++++++++++++++++++++++++++++++++-----
drivers/acpi/acpica/tbinstal.c | 161 ++++--------------------------
drivers/acpi/acpica/tbxface.c | 36 ++++++-
drivers/acpi/acpica/tbxfload.c | 2 +-
drivers/acpi/bus.c | 3 -
drivers/acpi/tables.c | 4 +-
include/acpi/acpixf.h | 15 +--
include/acpi/actbl.h | 1 +
9 files changed, 266 insertions(+), 183 deletions(-)
--
2.7.4
next prev parent reply other threads:[~2017-05-16 7:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 9:34 [PATCH] ACPICA: Detect duplicate SSDT tables Hans de Goede
2017-02-28 5:19 ` Zheng, Lv
2017-02-28 14:31 ` Hans de Goede
2017-02-28 15:46 ` Moore, Robert
2017-02-28 23:44 ` Hans de Goede
2017-03-01 0:11 ` Moore, Robert
2017-03-01 3:21 ` Zheng, Lv
2017-03-01 9:19 ` Hans de Goede
2017-03-01 20:38 ` Moore, Robert
2017-03-01 21:56 ` Rafael J. Wysocki
2017-03-02 1:59 ` Zheng, Lv
2017-03-02 15:24 ` Hans de Goede
2017-03-03 2:50 ` Zheng, Lv
2017-03-03 13:52 ` Hans de Goede
2017-03-13 6:01 ` Zheng, Lv
2017-05-16 7:13 ` Lv Zheng [this message]
2017-05-16 7:13 ` [RFC PATCH v2 1/5] ACPICA: Tables: Cleanup table handler invokers Lv Zheng
2017-05-16 7:13 ` [RFC PATCH v2 2/5] ACPICA: Tables: Do not validate signature for dynamic table load Lv Zheng
2017-05-16 7:13 ` [RFC PATCH v2 3/5] ACPICA: Tables: Change table duplication check to be related to acpi_gbl_verify_table_checksum Lv Zheng
2017-05-16 7:13 ` [RFC PATCH v2 4/5] ACPICA: Tables: Combine checksum/duplication verification together Lv Zheng
2017-05-16 7:13 ` [RFC PATCH v2 5/5] ACPICA: Tables: Add deferred table verification support Lv Zheng
2017-05-18 14:01 ` [RFC PATCH v2 0/5] ACPICA: Tables: Add deferred " Hans de Goede
2017-05-19 7:59 ` Zheng, Lv
2017-05-19 9:49 ` Hans de Goede
2017-05-18 9:57 ` [RFC PATCH v3 " Lv Zheng
2017-05-18 9:57 ` [RFC PATCH v3 1/5] ACPICA: Tables: Cleanup table handler invokers Lv Zheng
2017-05-18 9:57 ` [RFC PATCH v3 2/5] ACPICA: Tables: Do not validate signature for dynamic table load Lv Zheng
2017-05-18 9:57 ` [RFC PATCH v3 3/5] ACPICA: Tables: Change table duplication check to be related to acpi_gbl_verify_table_checksum Lv Zheng
2017-05-18 9:57 ` [RFC PATCH v3 4/5] ACPICA: Tables: Combine checksum/duplication verification together Lv Zheng
2017-05-18 9:57 ` [RFC PATCH v3 5/5] ACPICA: Tables: Add deferred table verification support Lv Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1494916766.git.lv.zheng@intel.com \
--to=lv.zheng@intel.com \
--cc=david.e.box@intel.com \
--cc=devel@acpica.org \
--cc=hdegoede@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=zetalog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).