Re: [PATCH 1/2] ACPI / PMIC: Add i2c address for thermal control

Andy Shevchenko
2020-05-12T09:14:02Z

On Tue, May 12, 2020 at 07:51:56AM +0200, Mauro Carvalho Chehab wrote:
> On Asus T101HA, we keep receiving those error messages:
>
> i915 0000:00:02.0: [drm] *ERROR* mipi_exec_pmic failed, error: -95
> intel_soc_pmic_exec_mipi_pmic_seq_element: Not implemented
> intel_soc_pmic_exec_mipi_pmic_seq_element: i2c-addr: 0x5e reg-addr 0x4b value 0x59 mask 0xff
>
> Because the opregion is missing the I2C address.
>

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/pmic/intel_pmic_chtdc_ti.c b/drivers/acpi/pmic/intel_pmic_chtdc_ti.c
> index 7ccd7d9660bc..a5101b07611a 100644
> --- a/drivers/acpi/pmic/intel_pmic_chtdc_ti.c
> +++ b/drivers/acpi/pmic/intel_pmic_chtdc_ti.c
> @@ -102,6 +102,7 @@ static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = {
> .power_table_count = ARRAY_SIZE(chtdc_ti_power_table),
> .thermal_table = chtdc_ti_thermal_table,
> .thermal_table_count = ARRAY_SIZE(chtdc_ti_thermal_table),
> + .pmic_i2c_address = 0x5e,
> };
>
> static int chtdc_ti_pmic_opregion_probe(struct platform_device *pdev)
> --
> 2.26.2
>

--
With Best Regards,
Andy Shevchenko