[PATCH] ACPI: video: Add backlight=native quirk for Dell OptiPlex 7770 AIO

[PATCH] ACPI: video: Add backlight=native quirk for Dell OptiPlex 7770 AIO

[Jan Schär]

The Dell OptiPlex 7770 AIO needs the same quirk as the 7760 AIO. The
backlight can be controlled with the native controller, intel_backlight,
but not with dell_uart_backlight.

I dumped the DSDT using acpidump, acpixtract and iasl, and confirmed
that it contains the DELL0501 device. When loading the
dell_uart_backlight driver with `rmmod dell_uart_backlight`, `modprobe
dell_uart_backlight dyndbg`, it reports "Firmware version: GL_Re_V18".

Fixes: cd8e468efb4f ("ACPI: video: Add Dell UART backlight controller detection")
Cc: stable@vger.kernel.org
Signed-off-by: Jan Schär <jan@jschaer.ch>
---
 drivers/acpi/video_detect.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 4cf74f173c78..4a2132ae28b4 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -878,6 +878,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7760 AIO"),
 		},
 	},
+	{
+	 .callback = video_detect_force_native,
+	 /* Dell OptiPlex 7770 AIO */
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7770 AIO"),
+		},
+	},
 
 	/*
 	 * Models which have nvidia-ec-wmi support, but should not use it.

base-commit: 591cd656a1bf5ea94a222af5ef2ee76df029c1d2
-- 
2.51.0

Re: [PATCH] ACPI: video: Add backlight=native quirk for Dell OptiPlex 7770 AIO

[Hans de Goede]

Hi,

On 11-Apr-26 11:26 AM, Jan Schär wrote:
> The Dell OptiPlex 7770 AIO needs the same quirk as the 7760 AIO. The
> backlight can be controlled with the native controller, intel_backlight,
> but not with dell_uart_backlight.
> 
> I dumped the DSDT using acpidump, acpixtract and iasl, and confirmed
> that it contains the DELL0501 device. When loading the
> dell_uart_backlight driver with `rmmod dell_uart_backlight`, `modprobe
> dell_uart_backlight dyndbg`, it reports "Firmware version: GL_Re_V18".
> 
> Fixes: cd8e468efb4f ("ACPI: video: Add Dell UART backlight controller detection")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jan Schär <jan@jschaer.ch>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Regards,

Hans



> ---
>  drivers/acpi/video_detect.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 4cf74f173c78..4a2132ae28b4 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -878,6 +878,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>  		DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7760 AIO"),
>  		},
>  	},
> +	{
> +	 .callback = video_detect_force_native,
> +	 /* Dell OptiPlex 7770 AIO */
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7770 AIO"),
> +		},
> +	},
>  
>  	/*
>  	 * Models which have nvidia-ec-wmi support, but should not use it.
> 
> base-commit: 591cd656a1bf5ea94a222af5ef2ee76df029c1d2