Re: [PATCH v4 15/16] device property: Add fwnode_get_next_parent()

[Sakari Ailus <sakari.ailus@linux.intel.com>]

On 03/13/17 23:58, Rafael J. Wysocki wrote:
> On Monday, March 06, 2017 04:19:29 PM Sakari Ailus wrote:
>> In order to differentiate the functionality between dropping a reference
>> to the node (or not) for the benefit of OF, introduce
>> fwnode_get_next_parent().
>>
>> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>> ---
>>  drivers/base/property.c  | 29 +++++++++++++++++++++++++++++
>>  include/linux/property.h |  1 +
>>  2 files changed, 30 insertions(+)
>>
>> diff --git a/drivers/base/property.c b/drivers/base/property.c
>> index b8c1017..defeba9 100644
>> --- a/drivers/base/property.c
>> +++ b/drivers/base/property.c
>> @@ -953,6 +953,35 @@ int device_add_properties(struct device *dev,
>>  EXPORT_SYMBOL_GPL(device_add_properties);
>>  
>>  /**
>> + * fwnode_get_next_parent - Iterate to the node's parent
>> + * @fwnode: Firmware whose parent is retrieved
>> + *
>> + * This is like fwnode_get_parent() except that it drops the refcount
>> + * on the passed node, making it suitable for iterating through a
>> + * node's parents.
>> + *
>> + * Returns a node pointer with refcount incremented, use
>> + * fwnode_handle_node() on it when done.
>> + */
>> +struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
>> +{
>> +	struct fwnode_handle *parent = NULL;
>> +
>> +	if (is_of_node(fwnode)) {
>> +		struct device_node *node;
>> +
>> +		node = of_get_next_parent(to_of_node(fwnode));
> 
> So I would fold the [14/15] into this one and then it should be clear why that
> change was useful.

Ok, I'll fold the two patches.

-- 
Regards,

Sakari Ailus
sakari.ailus@linux.intel.com