From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Garry Subject: Re: [PATCH v17 08/10] ACPI / scan: do not enumerate Indirect IO host children Date: Mon, 19 Mar 2018 11:13:07 +0000 Message-ID: References: <1521051359-34473-1-git-send-email-john.garry@huawei.com> <1521051359-34473-9-git-send-email-john.garry@huawei.com> <2309217.pWfZsU88YQ@aspire.rjw.lan> <906b3868-39a5-3807-23a4-dfc52c2e82c4@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Mika Westerberg , Lorenzo Pieralisi , Hanjun Guo , Rob Herring , Bjorn Helgaas , Arnd Bergmann , Mark Rutland , Olof Johansson , Dann Frazier , Andy Shevchenko , Rob Herring , Andy Shevchenko , Joe Perches , Benjamin Herrenschmidt , Linux PCI , Linux Kernel Mailing List , ACPI Devel Maling List List-Id: linux-acpi@vger.kernel.org On 19/03/2018 10:57, Rafael J. Wysocki wrote: > On Mon, Mar 19, 2018 at 11:48 AM, John Garry wrote: >> On 19/03/2018 10:30, Rafael J. Wysocki wrote: >>> >>> On Wednesday, March 14, 2018 7:15:57 PM CET John Garry wrote: >>>> >>>>> Through the logical PIO framework systems which otherwise have >>>>> no IO space access to legacy ISA/LPC devices may access these >>>>> devices through so-called "indirect IO" method. In this, IO >>>>> space accesses for non-PCI hosts are redirected to a host >>>>> LLDD to manually generate the IO space (bus) accesses. Hosts >>>>> are able to register a region in logical PIO space to map to >>>>> its bus address range. >>>>> >>>>> Indirect IO child devices have an associated host-specific bus >>>>> address. Special translation is required to map between >>>>> a logical PIO address for a device and it's host bus address. >>>>> >>>>> Since in the ACPI tables the child device IO resources would >>>>> be the host-specific values, it is required the ACPI scan code >>>>> should not enumerate these devices, and that this should be >>>>> the responsibility of the host driver so that it can "fixup" >>>>> the resources so that they map to the appropriate logical PIO >>>>> addresses. >>>>> >>>>> To avoid enumerating these child devices, we add a check from >>>>> acpi_device_enumeration_by_parent() as to whether the parent >>>>> for a device is a member of a known list of "indirect IO" hosts. >>>>> For now, the HiSilicon LPC host controller ID is added. >>>>> >>>>> Signed-off-by: John Garry >>>>> Acked-by: Rafael J. Wysocki >>> >>> You have my ACK here already. >>> >>> Since I've ACKed the [7/10] too, I don't think there's anything more I can >>> do >>> about this series and I'm assuming that it will be routed through other >>> trees. >>> >>> Thanks! >>> >> >> Hi Rafael, >> >> Thanks for this. >> >> Yes, I am working on getting this whole series routed through another tree. >> Actually I think 7+8 could go separately since there is no build dependency, >> but I will try to keep the series together. > > I can take the [7-8/10] if you want me to, so please let me know. > OK, thanks. Will do. John > Thanks! > > . >