public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Janne Grunau" <j@jannau.net>, "Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <bentiss@kernel.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/2] HID: lenovo: Remove CONFIG_ACPI dependency
Date: Sun, 18 May 2025 12:36:44 +0200	[thread overview]
Message-ID: <d57ff24a-bf6f-454d-9b00-8abf8071658e@app.fastmail.com> (raw)
In-Reply-To: <20250518-hid_lenovo_acpi_dependency-v1-2-afdb93b5d1a6@jannau.net>

On Sun, May 18, 2025, at 12:18, Janne Grunau via B4 Relay wrote:
> 
>  config HID_LENOVO
>  	tristate "Lenovo / Thinkpad devices"
> -	depends on ACPI
> -	select ACPI_PLATFORM_PROFILE
> +	depends on ACPI || !ACPI

Since ACPI is a 'bool' symbol, the 'ACPI || !ACPI' dependency
has no actual effect. I don't see any way that ACPI will ever
become a loadable module.

      Arnd

      reply	other threads:[~2025-05-18 10:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-18 10:18 [PATCH 0/2] Remove HID_LENOVO's dependency on ACPI Janne Grunau via B4 Relay
2025-05-18 10:18 ` [PATCH 1/2] ACPI: platform_profile: Stub platform_profile_cycle Janne Grunau via B4 Relay
2025-05-18 10:42   ` Arnd Bergmann
2025-05-18 14:45     ` Janne Grunau
2025-05-18 12:38   ` kernel test robot
2025-05-18 10:18 ` [PATCH 2/2] HID: lenovo: Remove CONFIG_ACPI dependency Janne Grunau via B4 Relay
2025-05-18 10:36   ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d57ff24a-bf6f-454d-9b00-8abf8071658e@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=bentiss@kernel.org \
    --cc=j@jannau.net \
    --cc=jikos@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox