From: Lv Zheng <lv.zheng@intel.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>
Cc: Lv Zheng <lv.zheng@intel.com>, Lv Zheng <zetalog@gmail.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
"David E. Box" <david.e.box@linux.intel.com>,
Bob Moore <robert.moore@intel.com>
Subject: [PATCH 08/27] ACPICA: Update handling of PCI ID lists.
Date: Wed, 30 Apr 2014 10:04:20 +0800 [thread overview]
Message-ID: <d6a663f690cde8e3a40ca0262cdd43b344df48c7.1398817612.git.lv.zheng@intel.com> (raw)
In-Reply-To: <cover.1398817612.git.lv.zheng@intel.com>
From: "David E. Box" <david.e.box@linux.intel.com>
More of a style cleanup. if hw_build_pci_list is to return a non-zero
status, it now deletes any partial ID list that has been constructed.
if it returns AE_OK, the caller is responsible for list deletion.
David Box.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
drivers/acpi/acpica/hwpci.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/acpica/hwpci.c b/drivers/acpi/acpica/hwpci.c
index e701d8c..6aade8e 100644
--- a/drivers/acpi/acpica/hwpci.c
+++ b/drivers/acpi/acpica/hwpci.c
@@ -140,11 +140,12 @@ acpi_hw_derive_pci_id(struct acpi_pci_id *pci_id,
/* Walk the list, updating the PCI device/function/bus numbers */
status = acpi_hw_process_pci_list(pci_id, list_head);
- }
- /* Always delete the list */
+ /* Delete the list */
+
+ acpi_hw_delete_pci_list(list_head);
+ }
- acpi_hw_delete_pci_list(list_head);
return_ACPI_STATUS(status);
}
@@ -187,6 +188,10 @@ acpi_hw_build_pci_list(acpi_handle root_pci_device,
while (1) {
status = acpi_get_parent(current_device, &parent_device);
if (ACPI_FAILURE(status)) {
+
+ /* Must delete the list before exit */
+
+ acpi_hw_delete_pci_list(*return_list_head);
return (status);
}
@@ -199,6 +204,10 @@ acpi_hw_build_pci_list(acpi_handle root_pci_device,
list_element = ACPI_ALLOCATE(sizeof(struct acpi_pci_device));
if (!list_element) {
+
+ /* Must delete the list before exit */
+
+ acpi_hw_delete_pci_list(*return_list_head);
return (AE_NO_MEMORY);
}
--
1.7.10
next prev parent reply other threads:[~2014-04-30 2:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 2:03 [PATCH 00/27] ACPICA: 20140424 Release Lv Zheng
2014-04-30 2:03 ` [PATCH 01/27] ACPICA: Utilities: Cleanup obsoleted global variables Lv Zheng
2014-04-30 2:03 ` [PATCH 02/27] ACPICA: Utilities: Deploy ACPI_DEBUGGER_EXEC for ACPI_DEBUGGER enabled code in utglobal.c Lv Zheng
2014-05-06 7:53 ` Pavel Machek
2014-05-06 8:58 ` Zheng, Lv
2014-05-06 11:08 ` Pavel Machek
2014-05-06 13:54 ` Zheng, Lv
2014-04-30 2:03 ` [PATCH 03/27] ACPICA: acpidump: Fix code issue in invoking fread in the loop Lv Zheng
2014-04-30 2:03 ` [PATCH 04/27] ACPICA: Update global variable definitions. No functional change Lv Zheng
2014-04-30 2:03 ` [PATCH 05/27] ACPICA: Update acpi_buffer_to_resource interface Lv Zheng
2014-04-30 2:04 ` [PATCH 06/27] ACPICA: Add support for LPIT table Lv Zheng
2014-04-30 2:04 ` [PATCH 07/27] ACPICA: Add support for _LPD and _PRP methods Lv Zheng
2014-04-30 2:04 ` Lv Zheng [this message]
2014-04-30 2:04 ` [PATCH 09/27] ACPICA: Comment updates - no functional change Lv Zheng
2014-04-30 2:04 ` [PATCH 10/27] ACPICA: OSL: Move external globals from utglobal.c to acpixf.h using ACPI_INIT_GLOBAL/ACPI_GLOBAL Lv Zheng
2014-04-30 2:04 ` [PATCH 11/27] ACPICA: OSL: Add configurability for memory allocation macros Lv Zheng
2014-04-30 2:04 ` [PATCH 12/27] ACPICA: OSL: Add configurability for error message functions Lv Zheng
2014-04-30 2:04 ` [PATCH 13/27] ACPICA: OSL: Add configurability for debug output functions Lv Zheng
2014-04-30 2:05 ` [PATCH 14/27] ACPICA: OSL: Add section to collect the divergence in acpixf.h Lv Zheng
2014-04-30 2:05 ` [PATCH 15/27] ACPICA: OSL: Add configurability for generic external functions Lv Zheng
2014-04-30 2:05 ` [PATCH 16/27] ACPICA: Linux header: Add support for stubbed externals Lv Zheng
2014-04-30 2:05 ` [PATCH 17/27] ACPICA: acpidump: Fix truncated RSDP signature validation Lv Zheng
2014-04-30 2:05 ` [PATCH 18/27] ACPICA: Back port of _PRP update Lv Zheng
2014-04-30 2:05 ` [PATCH 19/27] ACPICA: Back port of improvements on exception code Lv Zheng
2014-04-30 2:05 ` [PATCH 20/27] ACPICA: Tables: Fix invalid pointer accesses in acpi_tb_parse_root_table() Lv Zheng
2014-05-03 12:59 ` Josh Boyer
2014-05-05 0:43 ` Rafael J. Wysocki
2014-05-05 4:23 ` Zheng, Lv
2014-05-05 12:42 ` Josh Boyer
2014-05-06 0:43 ` Rafael J. Wysocki
2014-05-06 1:39 ` Zheng, Lv
2014-04-30 2:05 ` [PATCH 21/27] ACPICA: acpidump: Add support to force using RSDT Lv Zheng
2014-04-30 2:05 ` [PATCH 22/27] ACPICA: Tables: Add new mechanism to skip NULL entries in RSDT and XSDT Lv Zheng
2014-04-30 2:06 ` [PATCH 23/27] ACPICA: Tables: Remove old mechanism to validate if XSDT contains NULL entries Lv Zheng
2014-04-30 2:06 ` [PATCH 24/27] ACPICA: Remove extraneous error message for large number of GPEs Lv Zheng
2014-04-30 2:06 ` [PATCH 25/27] ACPICA: Events: Update GPE handling and initialization code Lv Zheng
2014-04-30 2:06 ` [PATCH 26/27] ACPICA: Comment/format update, no functional change Lv Zheng
2014-04-30 2:06 ` [PATCH 27/27] ACPICA: Update version to 20140424 Lv Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6a663f690cde8e3a40ca0262cdd43b344df48c7.1398817612.git.lv.zheng@intel.com \
--to=lv.zheng@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=zetalog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).