From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 201DF3911C9; Tue, 23 Jun 2026 04:02:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782187368; cv=none; b=Wu4J0oMCrh8pyqZwYjXc63RGZy5xIWzH3BL6CAqd8+IcmzhNU8+BQU/l6Mj56mANVzCBvf6MvbKc0RHT1oT4aViDjtgIhLqbFqNg4kiRGESQZ4qCpza1FN0fQMOgxeGuaTt/dALpFUzNaT5g8G4rq5WzjdYNbNae43cK61K0NQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782187368; c=relaxed/simple; bh=i6Xm2F9KwoMY97Fd4GqXtizxUOO3fXq5ZgvkpyrKpfo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dFde+sRG4XTyqywb/KgPms3eRTUHWdOfVH05JkaHM0mjbIhavvr6zpfwIjuGypJqqmk0HYqc41dTO6g0LR0Q3tvbhI1oB+993h0+Q3T+jV8UNbD+R5zk2X8zcxhQimsMg3v3qQy784FjneoFFxFSd3a3woGmLeNrzNLPp4iwbvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BuQBea0J; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BuQBea0J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 071361F000E9; Tue, 23 Jun 2026 04:02:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782187366; bh=0jCU7KhCjqf1LAHkZCuHO1mM0Uw8DGSPnamPprPucl0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=BuQBea0J5k39vlsfJHmWG5IZV3IdQy8USm69LnkvEVHVuXMcbeo9aHgX8QE3xTOl5 htuAzAXLR3Em/drP9aXAmRZnOnTYz1aBkRD4CDLeDkpb00rsK4xuXh1465dWlTYCoW kKAPXJjVHACfJP9yc80U0j/DP38RfCgiXMvHH+jQ3hKzOWhnDI2L1xaAcviOgaU5ck ITG4mPNaiBTssogJYsqwYjFxQ3PWdcDL+ms8+f+1i4HkI83HcuwIqyD9at3L2MjLQn 2ptCtam3GEc8Df7Eo1lNiotHDFhwa31FkpJrLTkAN+fGZzQobLoRH1IvLh7DCrtpTO pPUl0ypxGufEQ== Message-ID: Date: Tue, 23 Jun 2026 06:02:42 +0200 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] ACPICA: Unbreak tools build after switching over to strscpy_pad() To: "Rafael J. Wysocki" , Linux ACPI Cc: Thomas Renninger , LKML , Saket Dumbre , Kees Cook , "Chmielewski, Pawel" References: <12923581.O9o76ZdvQC@rafael.j.wysocki> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <12923581.O9o76ZdvQC@rafael.j.wysocki> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22. 06. 26, 20:23, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Commit 97f7d3f9c9ac ("ACPICA: Replace strncpy() with strscpy_pad() in > acpi_ut_safe_strncpy()") switched over the ACPICA code in the kernel to > using strscpy_pad() instead of a combination of strncpy() and manual > NUL-termination of the destination string, but it overlooked the fact > that tools also use the code in question and strscpy_pad() is not > defined in those builds. > > Address that by using the original ACPICA code in non-kernel builds. > > Fixes: 97f7d3f9c9ac ("ACPICA: Replace strncpy() with strscpy_pad() in acpi_ut_safe_strncpy()") > Reported-by: Jiri Slaby > Closes: https://lore.kernel.org/all/79e9e913-0fb1-4110-804b-c3b5d0edafe4@kernel > Signed-off-by: Rafael J. Wysocki > --- > drivers/acpi/acpica/utnonansi.c | 10 ++++++++++ > 1 file changed, 9 insertions(+) > > --- a/drivers/acpi/acpica/utnonansi.c > +++ b/drivers/acpi/acpica/utnonansi.c > @@ -168,7 +168,17 @@ void acpi_ut_safe_strncpy(char *dest, ch Hmm, how could this become 17, provided you are adding 9 lines to 7 lines? Fixed to 16 and applied -- testing. > { > /* Always terminate destination string */ > > +#ifdef __KERNEL__ > strscpy_pad(dest, source, dest_size); > +#else > + /* > + * strscpy_pad() is not defined in ACPICA tools builds, so use strncpy() > + * and directly NUL-terminate the destination string in that case. > + */ > + strncpy(dest, source, dest_size); > + dest[dest_size - 1] = 0; > +#endif > } > > #endif > > > -- js suse labs