From: Hanjun Guo <guohanjun@huawei.com>
To: Christoph Hellwig <hch@lst.de>, <will.deacon@arm.com>
Cc: <jean-philippe.brucker@arm.com>, <lorenzo.pieralisi@arm.com>,
<linux-acpi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI/IORT: Fix build without CONFIG_IOMMU_API
Date: Mon, 20 May 2019 18:34:04 +0800 [thread overview]
Message-ID: <dc52ba2d-76d7-ebb1-7284-bdcd71f6e010@huawei.com> (raw)
In-Reply-To: <20190520065746.17068-1-hch@lst.de>
On 2019/5/20 14:57, Christoph Hellwig wrote:
> IOMMU_FWSPEC_PCI_RC_ATS is only defined if CONFIG_IOMMU_API is
> enabled.
>
> Fixes: 5702ee24182f ("ACPI/IORT: Check ATS capability in root complex nodes")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/acpi/arm64/iort.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index 9058cb084b91..3e542b5d2a2d 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -1074,9 +1074,10 @@ const struct iommu_ops *iort_iommu_configure(struct device *dev)
> info.node = node;
> err = pci_for_each_dma_alias(to_pci_dev(dev),
> iort_pci_iommu_init, &info);
> -
> +#ifdef CONFIG_IOMMU_API
> if (!err && iort_pci_rc_supports_ats(node))
> dev->iommu_fwspec->flags |= IOMMU_FWSPEC_PCI_RC_ATS;
> +#endif
> } else {
> int i = 0;
This was reported, please refer to this patch from Lorenzo:
https://patchwork.kernel.org/patch/10946845/
Thanks
Hanjun
next prev parent reply other threads:[~2019-05-20 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 6:57 [PATCH] ACPI/IORT: Fix build without CONFIG_IOMMU_API Christoph Hellwig
2019-05-20 10:34 ` Hanjun Guo [this message]
2019-05-22 12:54 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc52ba2d-76d7-ebb1-7284-bdcd71f6e010@huawei.com \
--to=guohanjun@huawei.com \
--cc=hch@lst.de \
--cc=jean-philippe.brucker@arm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox