From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <rafael@kernel.org>, <linux-acpi@vger.kernel.org>,
<robert.moore@intel.com>, <amadeuszx.slawinski@linux.intel.com>,
<pierre-louis.bossart@linux.intel.com>
Subject: Re: [PATCH v6 2/4] ACPI: NHLT: Introduce API for the table
Date: Sat, 9 Mar 2024 11:39:40 +0100 [thread overview]
Message-ID: <dd7b08f4-2513-4b35-8364-2227780632ff@intel.com> (raw)
In-Reply-To: <ZesU9QXtM2n2eiZ1@smile.fi.intel.com>
On 2024-03-08 2:39 PM, Andy Shevchenko wrote:
> On Fri, Mar 08, 2024 at 08:32:38AM +0100, Cezary Rojewski wrote:
>> The table is composed of a range of endpoints with each describing
>> audio formats they support. Most of the operations involve iterating
>> over elements of the table and filtering them. Simplify the process by
>> implementing range of getters.
>>
>> While the acpi_nhlt_endpoint_mic_count() stands out a bit, it is a
>> critical component for any AudioDSP driver to know how many digital
>> microphones it is dealing with.
>
> ...
>
> + acpi.h ?
>
>> +#include <linux/export.h>
>
> + errno.h
>
> + minmax.h
>
> + printk.h
> + types.h
>
>> +#include <acpi/nhlt.h>
>
> ...
>
>> +#if IS_ENABLED(CONFIG_ACPI_NHLT)
>
> + kconfig.h ?
>
>> +#endif /* CONFIG_ACPI_NHLT */
>
Which tool helps you find out these? I want it too!
While I'll add the headers mentioned here, it feels weird to include
primitives such as errno.h or minmax.h. Majority of C-files found in the
kernel utilize such primitives yet the number of includes for these when
looking at the kernel as a whole is low.
Is there a "common defs" header in kernel? Looking for an equivalent of
'build-essentials' package.
next prev parent reply other threads:[~2024-03-09 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 7:32 [PATCH v6 0/4] ACPI: NHLT: Access and query helpers Cezary Rojewski
2024-03-08 7:32 ` [PATCH v6 1/4] ACPI: NHLT: Reintroduce types the table consists of Cezary Rojewski
2024-03-08 7:32 ` [PATCH v6 2/4] ACPI: NHLT: Introduce API for the table Cezary Rojewski
2024-03-08 13:39 ` Andy Shevchenko
2024-03-09 10:39 ` Cezary Rojewski [this message]
2024-03-11 9:48 ` Andy Shevchenko
2024-03-08 7:32 ` [PATCH v6 3/4] ACPI: NHLT: Drop redundant types Cezary Rojewski
2024-03-08 7:32 ` [PATCH v6 4/4] ACPI: NHLT: Streamline struct naming Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd7b08f4-2513-4b35-8364-2227780632ff@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox