From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 620C5EB64D9 for ; Thu, 6 Jul 2023 06:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233711AbjGFGlU (ORCPT ); Thu, 6 Jul 2023 02:41:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233174AbjGFGlS (ORCPT ); Thu, 6 Jul 2023 02:41:18 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA69C1BF0 for ; Wed, 5 Jul 2023 23:41:07 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-51e28b299adso524147a12.2 for ; Wed, 05 Jul 2023 23:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688625666; x=1691217666; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U84wbfrFvukSkpFpAQ72YzvXPcoC4HG//efb9ypi4vY=; b=FpVYqGF1XYTT/KAyacWSxk+i9pccD/FbD7y1brzTGwaLWI3Ciyw2T7Qii88QEHheZp BV4nAkn2mLDQl2R2hU8JYUqPt0x3bundqk3zAE7y9HNgAIhsOUcMoJecaS9y22XLWMXK phg68tYmFdkTiwPjTKqDUj9Jsrbm6Qk95mIzzeZHmHSAdpAcn8S9m7SSpU43VteqQJ+7 NEoaoB0jRjNzHfX1kWnFCnfYij4XWZ72QPaFiMThF1Dh3UIADMQfvt+YjunZW3KJBd9Z G8RsmTFaMrQVXjUx9rcL2SH/rl+jPhRQr5kDFMXWuZzLPEznDLHl8IchNOspMMqrLK8m mXZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688625666; x=1691217666; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U84wbfrFvukSkpFpAQ72YzvXPcoC4HG//efb9ypi4vY=; b=PLEWf9dH46uZ6PuYDFQBoLERq0R/CNfIMUVzFKVQXIBaRWPY1fJDv9QVSrFR4L4MR8 tXNWNHzZOZfJAgZAtF8O4aVccH2FlqA0c1YBIa8RKNfGQDM3v9/uroDfj+gktCOHQ4A8 GqwAs6UpvvkvTAi7DJyDpQi7Xe+R3/elXTAOnO02PjPjdNBlEsJrTUANgmX+S8qTORan EyeKO4eUjeMiACQgsYH1mZMJkCW45Cr6XhDc2BZHCUS1fQoqkgN0Dlg9vhEGPFcfwcDS /kczd+W9MUCSQ8qfstlgppICUcQcsgDzvUTuz7oRdYIM9vf5VPep/yjoEk/R295RfQrl N8ZQ== X-Gm-Message-State: ABy/qLZgOWtu+EyUWtWYAebcgRRK82jESkEj/OnOSC/PRSmjf/GC1TCW xFpuNn+QOa/O0I/p4YVzeFer1Q== X-Google-Smtp-Source: APBJJlGAra4B4N5W2yCWqVSgPSOS1FW5fd9tCfP5Cfaf2uSNLqrJHV9eQ5pbf0hv2OsdJjoh+ZQlXg== X-Received: by 2002:a05:6402:184e:b0:514:9929:1b01 with SMTP id v14-20020a056402184e00b0051499291b01mr774186edy.8.1688625666179; Wed, 05 Jul 2023 23:41:06 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id l26-20020aa7c3da000000b0051df6c2bb7asm376111edr.38.2023.07.05.23.41.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 23:41:05 -0700 (PDT) Message-ID: Date: Thu, 6 Jul 2023 08:41:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [External] Re: [PATCH v3 4/4] dt-bindings: firmware: Document ffitbl binding Content-Language: en-US To: =?UTF-8?B?6L+Q6L6J5bSU?= Cc: Conor Dooley , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, sunilvl@ventanamicro.com, ardb@kernel.org, palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, rminnich@gmail.com, mark.rutland@arm.com, lpieralisi@kernel.org, rafael@kernel.org, lenb@kernel.org, jdelvare@suse.com, yc.hung@mediatek.com, angelogioacchino.delregno@collabora.com, allen-kh.cheng@mediatek.com, pierre-louis.bossart@linux.intel.com, tinghan.shen@mediatek.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, geshijian@bytedance.com, weidong.wd@bytedance.com References: <20230705114251.661-1-cuiyunhui@bytedance.com> <20230705114251.661-5-cuiyunhui@bytedance.com> <20230705-oblivious-unstuffed-8e028a5b243c@spud> <07f88065-b9ca-5233-4048-5e61e1cdbe0c@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 06/07/2023 08:24, 运辉崔 wrote: > Hi Krzysztof, > > On Thu, Jul 6, 2023 at 2:01 PM Krzysztof Kozlowski > wrote: >> >> On 06/07/2023 05:43, 运辉崔 wrote: >>> Hi Conor, >>> >>> Added dts Maintainers, >>> >>> On Wed, Jul 5, 2023 at 11:07 PM Conor Dooley wrote: >>>> >>>> Hey, >>>> >>>> On Wed, Jul 05, 2023 at 07:42:51PM +0800, Yunhui Cui wrote: >>>>> Add the description for ffitbl subnode. >>>>> >>>>> Signed-off-by: Yunhui Cui >>>>> --- >>>>> .../devicetree/bindings/firmware/ffitbl.txt | 27 +++++++++++++++++++ >>>>> MAINTAINERS | 1 + >>>>> 2 files changed, 28 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/firmware/ffitbl.txt >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/firmware/ffitbl.txt b/Documentation/devicetree/bindings/firmware/ffitbl.txt >>>>> new file mode 100644 >>>>> index 000000000000..c42368626199 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/firmware/ffitbl.txt >>>> >>>> Firstly, new dt-bindings need to be done in yaml, not in text form. >>>> Secondly, you didn't re-run get_maintainer.pl after adding this binding, >>>> so you have not CCed any of the other dt-binding maintainers nor the >>>> devicetree mailing list. >>> >>> Re-run get_maintainer.pl and added maintainers into the maillist. >> >> >> This does not work like this. >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. >> >> You missed at least DT list (maybe more), so this won't be tested by our >> tools. Performing review on untested code might be a waste of time, thus >> I will skip this patch entirely till you follow the process allowing the >> patch to be tested. >> >> Please kindly resend and include all necessary To/Cc entries. > > This set of patches is applied on the tag next-20230706, and to > generate the mail list by scripts/get_maintainers.pl on the tag > > ./scripts/get_maintainer.pl > ../riscv/linux/v3-0004-dt-bindings-firmware-Document-ffitbl-binding.patch > Yunhui Cui cuiyunhui@bytedance.com (maintainer:FDT FIRMWARE INTERFACE (FFI)) > Rob Herring (maintainer:OPEN FIRMWARE AND > FLATTENED DEVICE TREE BINDINGS) > Krzysztof Kozlowski > (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) > Conor Dooley (maintainer:OPEN FIRMWARE AND > FLATTENED DEVICE TREE BINDINGS) > devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED > DEVICE TREE BINDINGS) > linux-kernel@vger.kernel.org (open list) > > What am I missing ? I did not receive the original patch. Neither did Patchwork. You cannot just reply to some comment and hope it will fix something. We don't have this patch simply. Best regards, Krzysztof