From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48F0F25A62E for ; Thu, 3 Apr 2025 19:56:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743710217; cv=none; b=gJnKnrQQUYbwFNlYfZ2+/9zn0yArpSUdqHQXZs8j8ey6JZK8AgLdpVSqNi1naDOzCEtWODIGd2oqOomRcwbog6QWLk3vzo2TQ0aBXC5Bon3fP4yv7mUWU+dMj8u3TOxKYTtymZW8Ct34D7L/0EyXYDr24c/FOFIuB56C0deATI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743710217; c=relaxed/simple; bh=QsfGg77/4wcXyQi/oDNqF6H4MrgvSDK8UQvAfwzGYtQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qcsna+74LSYDCg61cqUYB3W8M7rC86bQLPcr7zPkv5VoRMVFJSD46WWUVoInp1FqGnDT3bZDL4Jtys8szuazjE36QihS2qbAbBgq8su6nmo2QyFjSnzixIB5PIaZPdxmKFxSAQVfMpgzYBEmqGdBWyxwlFuuj0Ybg2LTREdtiEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BZpnJ5jS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BZpnJ5jS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04CACC4CEE3; Thu, 3 Apr 2025 19:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743710216; bh=QsfGg77/4wcXyQi/oDNqF6H4MrgvSDK8UQvAfwzGYtQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BZpnJ5jSl9OtB0RRAj4C/YiHrCyUWlggp0EXAh1oUK/XdMb03JOSIAuRIeV3fVRcb nSXs6AOj/dFRe+BXOLncRWHWV+peNRStozPzQwdIYYO/TVI/Q9UNUYoqBehUe3YWhs 70PmtnpTsmSwxZefd9pJqAzpWslLX+vVXpkHbgTCPcWBgpygpuwLuWBS/+FT8swTmc cEZIJpYsNblUSvNtGqnUP7PIMHr5s4mnI1Fyq5Z7dm98iJuDGqgNHgjF43UQx8djw1 +1jWNkqaiyBw5I9Mj2A9JK3Vnb+skL84OvFB5aBMupammtwk/Y+v3KxjvfxsMTMDMt WIKB6ji0yBZyg== Message-ID: Date: Thu, 3 Apr 2025 14:56:54 -0500 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ACPI: EC: Set ec_no_wakeup for Lenovo Go S To: Antheas Kapenekakis Cc: mario.limonciello@amd.com, rafael@kernel.org, Xino JS1 Ni , linux-acpi@vger.kernel.org, "derekjohn.clark@gmail.com" References: <20250331204442.1727618-1-superm1@kernel.org> <50cc3227-93eb-4cb8-8151-23e52ca91f80@kernel.org> <90d704dc-51ea-4c98-ba4a-f95460f65061@kernel.org> <1eb121e5-c0d3-49a8-9579-6ea5543ad4f9@kernel.org> <6a9268de-4072-4ef2-9f33-95cc783a8595@kernel.org> <8cdc5a58-2221-4332-9a47-e0f5b7832922@kernel.org> <411633ba-b693-4d08-81cf-426d20326434@kernel.org> Content-Language: en-US From: Mario Limonciello In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/2/2025 3:37 PM, Antheas Kapenekakis wrote: >> Maybe I'm failing at my search-engine-foo, could you point me at some >> docs about this AC/DC burst stuff? > > AC/DC Burst/AC/DC Burst Suppresed are the events in Sleep Study > https://learn.microsoft.com/en-us/windows-hardware/design/device-experiences/modern-standby-sleepstudy > > You can see those when running a sleep study and unplugging a > connector. I think suppressed is unplugging > > Then here is the description for plugging in a charger > https://learn.microsoft.com/en-us/windows-hardware/design/device-experiences/modern-standby-wake-sources#environmental-context-changes-1 > >> The Windows power manager will turn on the display when the battery subsystem has indicated >> AC power has been connected. The GPIO interrupt for power source changes must cause the >> ACPI _PSR method under the power supply device to be executed. The power subsystem must >> wake the SoC any time the power source changes, including when the system is attached or >> removed from a dock that has a battery or AC power source. After AC power is connected, >> the display will remain on for five seconds, unless there is input to the system during this five-second window. > > And here for unplugging: > https://learn.microsoft.com/en-us/windows-hardware/design/device-experiences/modern-standby-wake-sources#environmental-context-changes-2 > >> The GPIO interrupt for power source changes must cause the ACPI _PSR method under >> the power supply device to be executed. The power subsystem must wake the SoC any time >> the power source changes, including when the system is attached or removed from a dock >> that has a battery or AC power source. I suppose this could actually just be another way to say that there is a flurry of EC activity as a result of the ACPI SCI and they characterize that activity as a "burst" associated with unplug or plug. It would be good to find actual documentation though instead of guessing. > > I guess from the description it is not clear that the device stays on > for 5 seconds when unplugging, but from empirical testing I want to > say it does. It has been a while. I left 3 devices like an hour ago on > Windows and none of them managed to sleep, so I cannot verify this at > the moment though. > During "display off" there is other activity that goes on until reaching resiliency on Microsoft side. So it's not really cut and dry periods of time. If I was to hypothesize when the screen off wakeup occurs the OS looks at the amount of time that has passed and if there was any scheduled tasks for the next wakeup gets them done before going back down.