From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH 12/21] ACPI-video: Delete unnecessary if statement in acpi_video_switch_brightness() Date: Mon, 5 Sep 2016 18:59:07 +0200 Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> <897ebf36-2fe5-e109-adf6-b81b6e863d9a@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mout.web.de ([212.227.17.12]:60700 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965678AbcIEQ7Y (ORCPT ); Mon, 5 Sep 2016 12:59:24 -0400 In-Reply-To: <897ebf36-2fe5-e109-adf6-b81b6e863d9a@users.sourceforge.net> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: linux-acpi@vger.kernel.org, Hans de Goede , Len Brown , "Rafael J. Wysocki" , Zhang Rui Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: Markus Elfring Date: Mon, 5 Sep 2016 16:10:40 +0200 Move a function call into an else branch for successful function execution. Omit a duplicate check for the local variable "result" then at the end. Signed-off-by: Markus Elfring --- drivers/acpi/acpi_video.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index fe9b40e..0362a43 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -1372,14 +1372,12 @@ acpi_video_switch_brightness(struct work_struct *work) level_next = acpi_video_get_next_level(device, level_current, event); result = acpi_video_device_lcd_set_level(device, level_next); - - if (!result) - backlight_force_update(device->backlight, - BACKLIGHT_UPDATE_HOTKEY); - out: if (result) printk(KERN_ERR PREFIX "Failed to switch the brightness\n"); + else + backlight_force_update(device->backlight, + BACKLIGHT_UPDATE_HOTKEY); } int acpi_video_get_edid(struct acpi_device *device, int type, int device_id, -- 2.10.0