From: James Morse <james.morse@arm.com>
To: yaoaili126@163.com, rjw@rjwysocki.net, lenb@kernel.org,
tony.luck@intel.com, bp@alien8.de
Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
yangfeng1@kingsoft.com, CHENGUOMIN@kingsoft.com,
yaoaili@kingsoft.com
Subject: Re: [PATCH] Fix randconfig build error and code bug
Date: Fri, 6 Nov 2020 19:34:36 +0000 [thread overview]
Message-ID: <e35267a2-89f3-c5c1-119c-ce4eace8623e@arm.com> (raw)
In-Reply-To: <20201105114326.353021-1-yaoaili126@163.com>
Hello,
On 05/11/2020 11:43, yaoaili126@163.com wrote:
> From: Aili Yao <yaoaili@kingsoft.com>
>
> CONFIG_ACPI_APEI is not sufficient for ghes module global function
> replace it with CONFIG_ACPI_APEI_GHES.
>
> When gen_pool_alloc fails in ghes_in_mce_cper_entry_check, we still need
> to try other cper table to get it cleaned even we are likely to get another
> allocation fail.
This applies on top of your previous patches. It doesn't make sense in isolation.
When this happens its normal to post a 'v2' of your patch with the issue fixed.
If you only just posted the first version, then it is best to wait a little to give
reviewers a chance (multiple versions posted on the same day is too much). In this case
its good to reply to the build-robots' message saying how you've fixed it locally...
I think we need to find out whether your firmware supports GHES_ASSIST before we make
changes here...
Thanks,
James
next prev parent reply other threads:[~2020-11-06 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202011041829.KUaqiCq1-lkp () intel ! com>
2020-11-05 11:43 ` [PATCH] Fix randconfig build error and code bug yaoaili126
2020-11-06 19:34 ` James Morse [this message]
2020-11-10 20:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e35267a2-89f3-c5c1-119c-ce4eace8623e@arm.com \
--to=james.morse@arm.com \
--cc=CHENGUOMIN@kingsoft.com \
--cc=bp@alien8.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=yangfeng1@kingsoft.com \
--cc=yaoaili126@163.com \
--cc=yaoaili@kingsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox