linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Tony Luck <tony.luck@intel.com>, Len Brown <lenb@kernel.org>,
	Huang Ying <ying.huang@intel.com>, Borislav Petkov <bp@suse.de>,
	Tomasz Nowicki <tomasz.nowicki@linaro.org>,
	Jonathan Zhang <zjzhang@codeaurora.org>,
	Tyler Baicar <tbaicar@codeaurora.org>,
	linux-acpi@vger.kernel.org
Subject: [PATCH v2 2/2] ACPI / APEI: No remaining users of struct acpi_bert_region
Date: Fri, 12 May 2017 14:42:12 -0700	[thread overview]
Message-ID: <e5482112927d6b31aba43b88f1faba6c9fd96ab3.1494624795.git.tony.luck@intel.com> (raw)
In-Reply-To: <cover.1494624795.git.tony.luck@intel.com>
In-Reply-To: <cover.1494624795.git.tony.luck@intel.com>

From: Tony Luck <tony.luck@intel.com>

Version 6.1 of the ACPI specification. Section 18.3.1 "Boot Error
Source" clarified that the format of the Boot Error Region is a "Generic
Error Status Block". So we don't need separate (but identical) "struct
acpi_bert_region" and "struct acpi_hest_generic_status".

Code using acpi_bert_region has been changed to use acpi_hest_generic_status
instead. So we can delete the definition now.

Cc: Len Brown <lenb@kernel.org>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Tomasz Nowicki <tomasz.nowicki@linaro.org>
Cc: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org>
Cc: Tyler Baicar <tbaicar@codeaurora.org>
Cc: linux-acpi@vger.kernel.org
Reviewed-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
 include/acpi/actbl1.h | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
index b4ce55c008b0..b44663a87bd1 100644
--- a/include/acpi/actbl1.h
+++ b/include/acpi/actbl1.h
@@ -126,17 +126,11 @@ struct acpi_whea_header {
 struct acpi_table_bert {
 	struct acpi_table_header header;	/* Common ACPI table header */
 	u32 region_length;	/* Length of the boot error region */
-	u64 address;		/* Physical address of the error region */
-};
-
-/* Boot Error Region (not a subtable, pointed to by Address field above) */
-
-struct acpi_bert_region {
-	u32 block_status;	/* Type of error information */
-	u32 raw_data_offset;	/* Offset to raw error data */
-	u32 raw_data_length;	/* Length of raw error data */
-	u32 data_length;	/* Length of generic error data */
-	u32 error_severity;	/* Severity code */
+	u64 address;		/*
+				 * Physical address of the error region
+				 * which is a Generic Error Status Block
+				 * (struct acpi_hest_generic_status)
+				 */
 };
 
 /* Values for block_status flags above */
-- 
2.11.0


  parent reply	other threads:[~2017-05-12 21:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 18:10 [PATCH] ACPI / APEI: Boot Error Record Table processing was needlessly complicated Luck, Tony
2017-05-05 18:12 ` Luck, Tony
2017-05-05 19:52 ` Rafael J. Wysocki
2017-05-12 12:01 ` Borislav Petkov
2017-05-12 21:42   ` [PATCH v2 0/2] Clean up ACPI Boot Error Record Table code Luck, Tony
2017-05-12 21:42     ` [PATCH v2 1/2] ACPI / APEI: Boot Error Record Table processing was needlessly complicated Luck, Tony
2017-05-12 21:42     ` Luck, Tony [this message]
2017-05-12 21:46       ` [PATCH v2 2/2] ACPI / APEI: No remaining users of struct acpi_bert_region Rafael J. Wysocki
2017-05-12 22:32         ` Luck, Tony
2017-05-12 22:52           ` Rafael J. Wysocki
2017-05-16 22:12     ` [PATCH v2 0/2] Clean up ACPI Boot Error Record Table code Baicar, Tyler
2017-05-16 22:58       ` [PATCH v3] ACPI / APEI: Boot Error Record Table processing was needlessly complicated Luck, Tony
2017-05-19 21:39         ` Baicar, Tyler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5482112927d6b31aba43b88f1faba6c9fd96ab3.1494624795.git.tony.luck@intel.com \
    --to=tony.luck@intel.com \
    --cc=bp@suse.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tbaicar@codeaurora.org \
    --cc=tomasz.nowicki@linaro.org \
    --cc=ying.huang@intel.com \
    --cc=zjzhang@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).