From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luck, Tony" Subject: [PATCH v2 2/2] ACPI / APEI: No remaining users of struct acpi_bert_region Date: Fri, 12 May 2017 14:42:12 -0700 Message-ID: References: <20170512120118.zwhgtcbf4u4zshbn@pd.tnic> Return-path: Received: from mga09.intel.com ([134.134.136.24]:65355 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758767AbdELVnU (ORCPT ); Fri, 12 May 2017 17:43:20 -0400 In-Reply-To: In-Reply-To: References: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Tony Luck , Len Brown , Huang Ying , Borislav Petkov , Tomasz Nowicki , Jonathan Zhang , Tyler Baicar , linux-acpi@vger.kernel.org From: Tony Luck Version 6.1 of the ACPI specification. Section 18.3.1 "Boot Error Source" clarified that the format of the Boot Error Region is a "Generic Error Status Block". So we don't need separate (but identical) "struct acpi_bert_region" and "struct acpi_hest_generic_status". Code using acpi_bert_region has been changed to use acpi_hest_generic_status instead. So we can delete the definition now. Cc: Len Brown Cc: Huang Ying Cc: Borislav Petkov Cc: Tomasz Nowicki Cc: Jonathan (Zhixiong) Zhang Cc: Tyler Baicar Cc: linux-acpi@vger.kernel.org Reviewed-by: Borislav Petkov Signed-off-by: Tony Luck --- include/acpi/actbl1.h | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index b4ce55c008b0..b44663a87bd1 100644 --- a/include/acpi/actbl1.h +++ b/include/acpi/actbl1.h @@ -126,17 +126,11 @@ struct acpi_whea_header { struct acpi_table_bert { struct acpi_table_header header; /* Common ACPI table header */ u32 region_length; /* Length of the boot error region */ - u64 address; /* Physical address of the error region */ -}; - -/* Boot Error Region (not a subtable, pointed to by Address field above) */ - -struct acpi_bert_region { - u32 block_status; /* Type of error information */ - u32 raw_data_offset; /* Offset to raw error data */ - u32 raw_data_length; /* Length of raw error data */ - u32 data_length; /* Length of generic error data */ - u32 error_severity; /* Severity code */ + u64 address; /* + * Physical address of the error region + * which is a Generic Error Status Block + * (struct acpi_hest_generic_status) + */ }; /* Values for block_status flags above */ -- 2.11.0