From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9925C11F67 for ; Tue, 29 Jun 2021 17:00:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C627E61DE6 for ; Tue, 29 Jun 2021 17:00:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234214AbhF2RCe (ORCPT ); Tue, 29 Jun 2021 13:02:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30516 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233994AbhF2RCd (ORCPT ); Tue, 29 Jun 2021 13:02:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624986006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lvbNyAaXNTQ5069fiqWmGdMCCDHTjfldNskdDQUflO8=; b=iMBPB+Rvw0vtMfq8hYDmCssyQYjQmzleJWcZTJ1SF/g9G6xLUODAqm8/lcT3hLY+9odKTN Ms+J5yTyPrgbid2PjEGDB6EjGDMIQ3BoiDC2yt0Zb9sJA8oC/WGJEejpIfu6yLydjZgeyc vQ5d0iz3rOenRFGd0VdpCNqQgoXD9iw= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-595-GGsXezsVOiqQlEIecPcejw-1; Tue, 29 Jun 2021 13:00:04 -0400 X-MC-Unique: GGsXezsVOiqQlEIecPcejw-1 Received: by mail-ej1-f72.google.com with SMTP id f1-20020a1709064941b02903f6b5ef17bfso5962274ejt.20 for ; Tue, 29 Jun 2021 10:00:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lvbNyAaXNTQ5069fiqWmGdMCCDHTjfldNskdDQUflO8=; b=Fb88FMUhI3FvjCHEDQa1hBhFTW0YY1/W7/NrEUOm4WZklhLiPjsbGw/zlUK/pZFdcW yTUvyhBi53FiZHhIuCZ+EIbWRXFcUtY4kT7kqK3xOriKhDagEG/5TR/j7++RErPhRrpJ JCeYl1cHkBi1v4kLkVdVC2X38Ho2J94MYiyPIHhxaT0Fi5iWc6iMBKYgF079UEosQmhI 9CxntDLuGv42JHKu87kHKD9NpaAHaUZnwiGxh8ke0Oe3Kjx9NGVyClSan6rqky0LIVCA dXBD/Mj96xXnfhZ7s28Wc6Et6LrhKzjt7CleSZDtwtwf1GSxNyg4JEFtwyIVXyF8xSEP bXwg== X-Gm-Message-State: AOAM533AvC32o7DXawXlWZdhrX63L0zaEB+jo/NP2HX1B2z+Xl79YquQ AhxoslXCk2dwug2WP3Kgp+ZICrIcgXjWP3Gp/2OB4SQGPeWIKhCUglt/tQFdC5yRZRkNHz1OXCH AyE6MUgkjvV22oFRE+wFtvg== X-Received: by 2002:a17:906:d20b:: with SMTP id w11mr31393429ejz.242.1624986002911; Tue, 29 Jun 2021 10:00:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqRVaEdobduYFFV7UZZexaizEQ7YzvICKGT0JHpiGhiMaEkOSXzTmU+KuaIvfsal9TLSHd+A== X-Received: by 2002:a17:906:d20b:: with SMTP id w11mr31393419ejz.242.1624986002720; Tue, 29 Jun 2021 10:00:02 -0700 (PDT) Received: from x1.localdomain ([2a0e:5700:4:11:334c:7e36:8d57:40cb]) by smtp.gmail.com with ESMTPSA id i6sm8489096ejr.68.2021.06.29.10.00.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Jun 2021 10:00:02 -0700 (PDT) Subject: Re: [PATCH] mfd: axp20x: Update AXP288 volatile ranges To: wens@csie.org Cc: Lee Jones , linux-acpi@vger.kernel.org, linux-kernel , Clamshell References: <20210626132732.40063-1-hdegoede@redhat.com> From: Hans de Goede Message-ID: Date: Tue, 29 Jun 2021 19:00:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, Thank you for the review. On 6/29/21 4:19 AM, Chen-Yu Tsai wrote: > Hi, > > On Sat, Jun 26, 2021 at 9:29 PM Hans de Goede wrote: >> >> On Cherry Trail devices with an AXP288 PMIC the external SD-card slot >> used the AXP's DLDO2 as card-voltage and either DLDO3 or GPIO1LDO >> (GPIO1 pin in low noise LDO mode) as signal-voltage. >> >> These regulators are turned on/off and in case of the signal-voltage >> also have their output-voltage changed by the _PS0 and _PS3 power- >> management ACPI methods on the MMC-controllers ACPI fwnode as well as >> by the _DSM ACPI method for changing the signal voltage. >> >> The AML code implementing these methods is directly accessing the >> PMIC through ACPI I2C OpRegion accesses, instead of using the special >> PMIC OpRegion handled by drivers/acpi/pmic/intel_pmic_xpower.c . >> >> This means that the contents of the involved PMIC registers can change >> without the change being made through the regmap interface, so regmap >> should not cache the contents of these registers. >> >> Mark the LDO power on/off, the LDO voltage control and the GPIO1 control >> register as volatile, to avoid regmap caching their contents. >> >> Specifically this fixes an issue on some models where the i915 driver >> toggles another LDO using the same on/off register on/off through >> MIPI sequences (through intel_soc_pmic_exec_mipi_pmic_seq_element()) >> which then writes back a cached on/off register-value where the >> card-voltage is off causing the external sdcard slot to stop working >> when the screen goes blank, or comes back on again. >> >> Note the AXP288 PMIC is only used on Bay- and Cherry-Trail platforms, >> so even though this is an ACPI specific problem there is no need to >> make the new volatile ranges conditional since these platforms always >> use ACPI. >> >> Fixes: dc91c3b6fe66 ("mfd: axp20x: Mark AXP20X_VBUS_IPSOUT_MGMT as volatile") > > Maybe you want > > Fixes: cd53216625a0 ("mfd: axp20x: Fix axp288 volatile ranges") > > and then list the other one as a prerequisite? Or just list both tags. I've just listed both for v2 of this patch. > Should we CC stable on this? That is not necessary, the fix will automatically get picked up in the relevant stable series based on the Fixes tag (in my experience). >> Reported-and-tested-by: Clamshell >> Signed-off-by: Hans de Goede >> --- >> drivers/mfd/axp20x.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c >> index 3eae04e24ac8..db6a21465594 100644 >> --- a/drivers/mfd/axp20x.c >> +++ b/drivers/mfd/axp20x.c >> @@ -125,12 +125,13 @@ static const struct regmap_range axp288_writeable_ranges[] = { >> >> static const struct regmap_range axp288_volatile_ranges[] = { >> regmap_reg_range(AXP20X_PWR_INPUT_STATUS, AXP288_POWER_REASON), >> + regmap_reg_range(AXP22X_PWR_OUT_CTRL1, AXP22X_ALDO3_V_OUT), > > This region also covers the voltage and on/off controls for the buck > regulators. Maybe include that in your commit message if that was the > intent, or skip over them if not? This was intentional I've added the following comment to the commit msg for v2: "The regulator register-range now marked volatile also includes the buck regulator control registers. This is done on purpose these are normally not touched by the AML code, but they are updated directly by the SoC's PUNIT which means that they may also change without going through regmap." Regards, Hans > > > Thanks > ChenYu > >> regmap_reg_range(AXP288_BC_GLOBAL, AXP288_BC_GLOBAL), >> regmap_reg_range(AXP288_BC_DET_STAT, AXP20X_VBUS_IPSOUT_MGMT), >> regmap_reg_range(AXP20X_CHRG_BAK_CTRL, AXP20X_CHRG_BAK_CTRL), >> regmap_reg_range(AXP20X_IRQ1_EN, AXP20X_IPSOUT_V_HIGH_L), >> regmap_reg_range(AXP20X_TIMER_CTRL, AXP20X_TIMER_CTRL), >> - regmap_reg_range(AXP22X_GPIO_STATE, AXP22X_GPIO_STATE), >> + regmap_reg_range(AXP20X_GPIO1_CTRL, AXP22X_GPIO_STATE), >> regmap_reg_range(AXP288_RT_BATT_V_H, AXP288_RT_BATT_V_L), >> regmap_reg_range(AXP20X_FG_RES, AXP288_FG_CC_CAP_REG), >> }; >> -- >> 2.31.1 >> >