From: Mark Pearson <markpearson@lenovo.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Mario Limonciello <mario.limonciello@dell.com>,
Elia Devito <eliadevito@gmail.com>,
Bastien Nocera <hadess@hadess.net>,
Benjamin Berg <bberg@redhat.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Darren Hart <dvhart@infradead.org>
Subject: Re: [External] Re: [PATCH 3/3] platform/x86: thinkpad_acpi: Add platform profile support
Date: Tue, 10 Nov 2020 09:41:28 -0500 [thread overview]
Message-ID: <e823b5cd-d050-0748-ebee-0d26f7ebec4f@lenovo.com> (raw)
In-Reply-To: <CAHp75VePnNAmiOHKpLui3J_nh6_qVsbEGB4rjEAnFVhxkxbGsg@mail.gmail.com>
Hi Andy,
On 10/11/2020 05:06, Andy Shevchenko wrote:
> On Tue, Nov 10, 2020 at 5:34 AM Mark Pearson <markpearson@lenovo.com> wrote:
>>
>> Add support to thinkpad_acpi for Lenovo platforms that have DYTC
>> version 5 support or newer to use the platform profile feature.
>>
>> This will allow users to determine and control the platform modes
>> between low-power, balanced operation and performance modes.
>
> ...
>
>> +#if defined(CONFIG_ACPI_PLATFORM_PROFILE)
>> + platform_profile_unregister();
>> +#endif
>> + dytc_available = false;
>
>> +#if defined(CONFIG_ACPI_PLATFORM_PROFILE)
>> + dytc_profile_refresh();
>> +#endif
>
> Better to use (e.g. test coverage) if (IS_BUILTIN()) / if (IS_ENABLE()) / etc.
>
Thanks - I wasn't aware of those. I'll update
Mark
next prev parent reply other threads:[~2020-11-10 14:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 3:31 [PATCH 0/3] Platform Profile support Mark Pearson
2020-11-10 3:31 ` [PATCH 1/3] Documentation: Add documentation for new platform_profile sysfs attribute Mark Pearson
2020-11-10 10:03 ` Andy Shevchenko
2020-11-10 14:09 ` [External] " Mark Pearson
2020-11-10 3:31 ` [PATCH 2/3] ACPI: platform-profile: Add platform profile support Mark Pearson
2020-11-10 10:15 ` Barnabás Pőcze
2020-11-10 14:32 ` [External] " Mark Pearson
2020-11-10 23:48 ` Barnabás Pőcze
2020-11-11 10:29 ` Hans de Goede
2020-11-10 10:26 ` Andy Shevchenko
2020-11-10 14:39 ` [External] " Mark Pearson
2020-11-10 12:53 ` Rafael J. Wysocki
2020-11-10 14:40 ` [External] " Mark Pearson
2020-11-10 3:31 ` [PATCH 3/3] platform/x86: thinkpad_acpi: " Mark Pearson
2020-11-10 10:06 ` Andy Shevchenko
2020-11-10 14:41 ` Mark Pearson [this message]
2020-11-19 16:37 ` [PATCH 0/3] Platform Profile support Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e823b5cd-d050-0748-ebee-0d26f7ebec4f@lenovo.com \
--to=markpearson@lenovo.com \
--cc=andy.shevchenko@gmail.com \
--cc=bberg@redhat.com \
--cc=dvhart@infradead.org \
--cc=eliadevito@gmail.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox