From mboxrd@z Thu Jan 1 00:00:00 1970 From: Len Brown Subject: [PATCH 28/30] cpuidle / ACPI: fix potential NULL pointer dereference Date: Tue, 9 Oct 2012 01:54:18 -0400 Message-ID: References: <1349762060-25334-1-git-send-email-lenb@kernel.org> Reply-To: Len Brown Return-path: In-Reply-To: <1349762060-25334-1-git-send-email-lenb@kernel.org> In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org To: linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Wei Yongjun , Len Brown List-Id: linux-acpi@vger.kernel.org From: Wei Yongjun The dereference should be moved below the NULL test. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun Signed-off-by: Len Brown --- drivers/acpi/processor_idle.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 3655ab9..e8086c7 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -1132,7 +1132,7 @@ static int acpi_processor_setup_cpuidle_states(struct acpi_processor *pr) int acpi_processor_hotplug(struct acpi_processor *pr) { int ret = 0; - struct cpuidle_device *dev = per_cpu(acpi_cpuidle_device, pr->id); + struct cpuidle_device *dev; if (disabled_by_idle_boot_param()) return 0; @@ -1147,6 +1147,7 @@ int acpi_processor_hotplug(struct acpi_processor *pr) if (!pr->flags.power_setup_done) return -ENODEV; + dev = per_cpu(acpi_cpuidle_device, pr->id); cpuidle_pause_and_lock(); cpuidle_disable_device(dev); acpi_processor_get_power_info(pr); -- 1.8.0.rc1