From: "Murad Masimov " <m.masimov@mt-integration.ru>
To: Ira Weiny <ira.weiny@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
"Dan Williams" <dan.j.williams@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"syzbot+c80d8dc0d9fa81a3cd8c@syzkaller.appspotmail.com"
<syzbot+c80d8dc0d9fa81a3cd8c@syzkaller.appspotmail.com>
Subject: Re: [PATCH] acpi: nfit: fix narrowing conversion in acpi_nfit_ctl
Date: Mon, 27 Jan 2025 18:37:41 +0000 [thread overview]
Message-ID: <e8e39191429d4211a0e9a784c5eb2288@mt-integration.ru> (raw)
In-Reply-To: <6793e1945e9f2_9caff29489@iweiny-mobl.notmuch>
> I tend to agree this is not ideal. But IMO the issue is that family is
> treated as an int throughout the code rather than u64. Even u32 would
> have been better than int because negative numbers are not allowed AFAICT
> just skimming the code.
>
> Unfortunately, ripping through the code to change family to u32 is
> probably not worth the churn. I'll think on this but I'm tempted to apply
> this.
>
> Ira
Hi,
I believe this patch is better suited for the stable branches.
Additionally, replacing int to u32 or u64 in all relevant parts of the
code seems too risky, as it could potentially introduce new bugs.
Given the discussion so far, would it be appropriate to resend the same
patch, but with a more detailed commit message this time?
Thank you
prev parent reply other threads:[~2025-01-27 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 16:39 [PATCH] acpi: nfit: fix narrowing conversion in acpi_nfit_ctl Murad Masimov
2025-01-23 23:43 ` Dave Jiang
2025-01-24 14:17 ` Murad Masimov
2025-01-24 16:58 ` Alison Schofield
2025-01-24 18:53 ` Ira Weiny
2025-01-27 18:37 ` Murad Masimov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8e39191429d4211a0e9a784c5eb2288@mt-integration.ru \
--to=m.masimov@mt-integration.ru \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=nvdimm@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+c80d8dc0d9fa81a3cd8c@syzkaller.appspotmail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox