From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70849C001DF for ; Mon, 31 Jul 2023 07:29:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbjGaH3X (ORCPT ); Mon, 31 Jul 2023 03:29:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231789AbjGaH2N (ORCPT ); Mon, 31 Jul 2023 03:28:13 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 645543AA8 for ; Mon, 31 Jul 2023 00:24:53 -0700 (PDT) Received: from [192.168.10.12] (unknown [39.45.136.149]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id AD7E76607176; Mon, 31 Jul 2023 08:24:39 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690788282; bh=/4EFsZqLFoVXx8eZb5fZ/Qj7O9z+8Q382OC3VuC9q8w=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=H60UBoMe7xus2FhlBJkQ6lv7P3ec68c7qOU7P7BeGFyAl80v6jGRTtwV7YNn3DmmJ rGnIF1NHSyAeCtaDTG8xV++OGFQ/5FLr3FzEJHLgikgPbFfxBQQTerM/9b+NrLnvs9 cRJEOvjf/DawrArvBTDVCKhkL98zs8WXjaSvqgr2uE0yLqFdcWc2NVuhqVXqj9aInZ RLpu8ohSkOEqWzYhIsfI39H8d6q/jbgKyDhIYuoOQ5BDxTxDR+9ramtTEtjWF/ny05 LUMeMjIlj5z1hs9WJ8B6xHw4JdoDr2WH5Jtbe45/5Vy8qmTF+aEXtYRP6C9P36Dj29 4bnNF5XjmosWw== Message-ID: Date: Mon, 31 Jul 2023 12:24:34 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Muhammad Usama Anjum , guillaume.tucker@collabora.com, denys.f@collabora.com, ricardo.canuelo@collabora.com, chrome-platform@lists.linux.dev, linux-acpi@vger.kernel.org Subject: Re: [PATCH v3] platform/chrome: chromeos_acpi: support official HID GOOG0016 To: Tzung-Bi Shih , bleung@chromium.org, groeck@chromium.org, rafael@kernel.org, lenb@kernel.org References: <20230731024214.908235-1-tzungbi@kernel.org> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20230731024214.908235-1-tzungbi@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 7/31/23 7:42 AM, Tzung-Bi Shih wrote: > Support official HID GOOG0016 for ChromeOS ACPI (see [1]). > > [1]: https://crrev.com/c/2266713 > > Signed-off-by: Tzung-Bi Shih Reviewed-by: Muhammad Usama Anjum > --- > Changes from v2[2]: > - Instead of replacing, appending "GOOG0016" in sysfs-driver-chromeos-acpi. > > Changes from v1[3]: > - Preserve the PNP ID GGL0001 for backward compatible to older firmwares. > - Modify commit title and message accordingly. > > [2]: https://patchwork.kernel.org/project/chrome-platform/patch/20230728065438.4026629-1-tzungbi@kernel.org/ > [3]: https://patchwork.kernel.org/project/chrome-platform/patch/20230728014256.3836298-1-tzungbi@kernel.org/ > > .../ABI/testing/sysfs-driver-chromeos-acpi | 15 +++++++++++++++ > .../firmware-guide/acpi/chromeos-acpi-device.rst | 5 ++--- > drivers/platform/chrome/chromeos_acpi.c | 2 +- > 3 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-driver-chromeos-acpi b/Documentation/ABI/testing/sysfs-driver-chromeos-acpi > index c308926e1568..22082f9a7922 100644 > --- a/Documentation/ABI/testing/sysfs-driver-chromeos-acpi > +++ b/Documentation/ABI/testing/sysfs-driver-chromeos-acpi > @@ -1,4 +1,5 @@ > What: /sys/bus/platform/devices/GGL0001:*/BINF.2 > + /sys/bus/platform/devices/GOOG0016:*/BINF.2 > Date: May 2022 > KernelVersion: 5.19 > Description: > @@ -10,6 +11,7 @@ Description: > == =============================== > > What: /sys/bus/platform/devices/GGL0001:*/BINF.3 > + /sys/bus/platform/devices/GOOG0016:*/BINF.3 > Date: May 2022 > KernelVersion: 5.19 > Description: > @@ -23,6 +25,7 @@ Description: > == ===================================== > > What: /sys/bus/platform/devices/GGL0001:*/CHSW > + /sys/bus/platform/devices/GOOG0016:*/CHSW > Date: May 2022 > KernelVersion: 5.19 > Description: > @@ -38,6 +41,7 @@ Description: > ==== =========================================== > > What: /sys/bus/platform/devices/GGL0001:*/FMAP > + /sys/bus/platform/devices/GOOG0016:*/FMAP > Date: May 2022 > KernelVersion: 5.19 > Description: > @@ -45,6 +49,7 @@ Description: > processor firmware flashmap. > > What: /sys/bus/platform/devices/GGL0001:*/FRID > + /sys/bus/platform/devices/GOOG0016:*/FRID > Date: May 2022 > KernelVersion: 5.19 > Description: > @@ -52,6 +57,7 @@ Description: > main processor firmware. > > What: /sys/bus/platform/devices/GGL0001:*/FWID > + /sys/bus/platform/devices/GOOG0016:*/FWID > Date: May 2022 > KernelVersion: 5.19 > Description: > @@ -59,6 +65,7 @@ Description: > main processor firmware. > > What: /sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.0 > + /sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.0 > Date: May 2022 > KernelVersion: 5.19 > Description: > @@ -73,6 +80,7 @@ Description: > =========== ================================== > > What: /sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.1 > + /sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.1 > Date: May 2022 > KernelVersion: 5.19 > Description: > @@ -84,6 +92,7 @@ Description: > == ======================= > > What: /sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.2 > + /sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.2 > Date: May 2022 > KernelVersion: 5.19 > Description: > @@ -91,18 +100,21 @@ Description: > controller. > > What: /sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.3 > + /sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.3 > Date: May 2022 > KernelVersion: 5.19 > Description: > Returns name of the GPIO controller. > > What: /sys/bus/platform/devices/GGL0001:*/HWID > + /sys/bus/platform/devices/GOOG0016:*/HWID > Date: May 2022 > KernelVersion: 5.19 > Description: > Returns hardware ID for the Chromebook. > > What: /sys/bus/platform/devices/GGL0001:*/MECK > + /sys/bus/platform/devices/GOOG0016:*/MECK > Date: May 2022 > KernelVersion: 5.19 > Description: > @@ -113,6 +125,7 @@ Description: > present, or if the firmware was unable to read the extended registers, this buffer size can be zero. > > What: /sys/bus/platform/devices/GGL0001:*/VBNV.0 > + /sys/bus/platform/devices/GOOG0016:*/VBNV.0 > Date: May 2022 > KernelVersion: 5.19 > Description: > @@ -122,6 +135,7 @@ Description: > clock data). > > What: /sys/bus/platform/devices/GGL0001:*/VBNV.1 > + /sys/bus/platform/devices/GOOG0016:*/VBNV.1 > Date: May 2022 > KernelVersion: 5.19 > Description: > @@ -129,6 +143,7 @@ Description: > storage block. > > What: /sys/bus/platform/devices/GGL0001:*/VDAT > + /sys/bus/platform/devices/GOOG0016:*/VDAT > Date: May 2022 > KernelVersion: 5.19 > Description: > diff --git a/Documentation/firmware-guide/acpi/chromeos-acpi-device.rst b/Documentation/firmware-guide/acpi/chromeos-acpi-device.rst > index f37fc90ce340..89419e116413 100644 > --- a/Documentation/firmware-guide/acpi/chromeos-acpi-device.rst > +++ b/Documentation/firmware-guide/acpi/chromeos-acpi-device.rst > @@ -5,9 +5,8 @@ Chrome OS ACPI Device > ===================== > > Hardware functionality specific to Chrome OS is exposed through a Chrome OS ACPI device. > -The plug and play ID of a Chrome OS ACPI device is GGL0001. GGL is a valid PNP ID of Google. > -PNP ID can be used with the ACPI devices according to the guidelines. The following ACPI > -objects are supported: > +The plug and play ID of a Chrome OS ACPI device is GGL0001 and the hardware ID is > +GOOG0016. The following ACPI objects are supported: > > .. flat-table:: Supported ACPI Objects > :widths: 1 2 > diff --git a/drivers/platform/chrome/chromeos_acpi.c b/drivers/platform/chrome/chromeos_acpi.c > index 50d8a4d4352d..1cc01d893ada 100644 > --- a/drivers/platform/chrome/chromeos_acpi.c > +++ b/drivers/platform/chrome/chromeos_acpi.c > @@ -235,9 +235,9 @@ static int chromeos_acpi_device_probe(struct platform_device *pdev) > return 0; > } > > -/* GGL is valid PNP ID of Google. PNP ID can be used with the ACPI devices. */ > static const struct acpi_device_id chromeos_device_ids[] = { > { "GGL0001", 0 }, > + { "GOOG0016", 0 }, > {} > }; > MODULE_DEVICE_TABLE(acpi, chromeos_device_ids); -- BR, Muhammad Usama Anjum