From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18FFDC433E6 for ; Wed, 27 Jan 2021 21:54:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD4F464DA3 for ; Wed, 27 Jan 2021 21:54:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236479AbhA0VyQ (ORCPT ); Wed, 27 Jan 2021 16:54:16 -0500 Received: from mga03.intel.com ([134.134.136.65]:47142 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236464AbhA0VyH (ORCPT ); Wed, 27 Jan 2021 16:54:07 -0500 IronPort-SDR: pPJdJ7OhKGWm/xDgx8dJSJJgooMULYk+mJ6eAz0oe9fHCI5d/qMqmcNVJPKscHYn4QG1XkwRxz SdaWOFZJc8yg== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="180217730" X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="180217730" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 13:52:24 -0800 IronPort-SDR: gteFvDl2CjPds7XthdSGQbmnnQ47OwYTSe9MJotOb61g2jPaf+hF8uIX/AdjyjLuhRyjeLARr5 OvCaX20Yu77A== X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="357204084" Received: from johaleryn.amr.corp.intel.com (HELO [10.209.174.152]) ([10.209.174.152]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 13:52:22 -0800 Subject: Re: Crash in acpi_ns_validate_handle triggered by soundwire on Linux 5.10 To: =?UTF-8?Q?Marcin_=c5=9alusarz?= Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , "Rafael J. Wysocki" , "Rafael J. Wysocki" , ACPI Devel Maling List , Vinod Koul , Bard Liao , Len Brown References: <1f0f7273-597e-cdf0-87d1-908e56c13133@linux.intel.com> <1dc2639a-ecbc-c554-eaf6-930256dcda96@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Wed, 27 Jan 2021 15:52:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 1/27/21 1:18 PM, Marcin Ślusarz wrote: > śr., 27 sty 2021 o 18:28 Pierre-Louis Bossart > napisał(a): >>> Weird, I can't reproduce this problem with my self-compiled kernel :/ >>> I don't even see soundwire modules loaded in. Manually loading them of course >>> doesn't do much. >>> >>> Previously I could boot into the "faulty" kernel by using "recovery mode", but >>> I can't do that anymore - it crashes too. >>> >>> Maybe there's some kind of race and this bug depends on some specific >>> ordering of events? >> >> missing Kconfig? >> You need CONFIG_SOUNDWIRE and CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE >> selected to enter this sdw_intel_acpi_scan() routine. > > It was a PEBKAC, but a slightly different one. I won't bore you with > (embarrassing) details ;). > > I reproduced the problem, tested both your and Rafael's patches > and the kernel still crashes, with the same stack trace. > (Yes, I'm sure I booted the right kernel :) > > Why "recovery mode" stopped working (or worked previously) is still a mystery. ok, well if you have a consistent failure that's better to some extent. Maybe a bit of explanations of what this routine tries to do: when SoundWire is enabled in a system, we need to have the following pattern in the DSDT