Re: [PATCH v1 1/1] ACPI: CPPC: Fix access width used for PCC registers

Jarred White
2024-04-08T20:19:01Z

On 4/1/2024 10:45 AM, Vanshidhar Konda wrote:
> On Mon, Apr 01, 2024 at 09:48:28AM -0700, Easwar Hariharan wrote:
>> Hi Vanshi,
>>
>> Thanks for testing and catching this. One comment below, but Jarred is
>> OOF for a couple days so
>> we'll get back again after testing on our platform.
>>
>> On 3/29/2024 3:00 PM, Vanshidhar Konda wrote:
>>> Commit 2f4a4d63a193 ("ACPI: CPPC: Use access_width over bit_width for
>>> system memory accesses") modified cpc_read/cpc_write to use
>>> access_width to
>>> read CPC registers. For PCC registers the access width field in the ACPI
>>> register macro specifies the PCC subspace id. For non-zero PCC
>>> subspace id
>>> the access width is incorrectly treated as access width. This causes
>>> errors
>>> when reading from PCC registers in the CPPC driver.
>>>
>>> For PCC registers base the size of read/write on the bit width field.
>>> The debug message in cpc_read/cpc_write is updated to print relevant
>>> information for the address space type used to read the register.
>>>
>>> Fixes: 2f4a4d63a193 ("ACPI: CPPC: Use access_width over bit_width for
>>> system memory accesses")
>>> Signed-off-by: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
>>> ---

Hi Vanshi,

The patch is good.

You can add,
Reviewed-by: Jarred White <jarredwhite@linux.microsoft.com>
Tested-by: Jarred White <jarredwhite@linux.microsoft.com>

We also found another bug in the process of testing, which we will
submitting a patch for.

Thanks,
Jarred