From: Hans de Goede <hdegoede@redhat.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org,
stable@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Bob Moore <robert.moore@intel.com>,
Erik Kaneda <erik.kaneda@intel.com>
Subject: Re: [PATCH v2] pinctrl: cherryview: Ensure _REG(ACPI_ADR_SPACE_GPIO, 1) gets called
Date: Thu, 8 Oct 2020 19:39:10 +0200 [thread overview]
Message-ID: <efcd512b-9072-5807-b7e6-79a2aa413273@redhat.com> (raw)
In-Reply-To: <20201008155222.GW2495@lahna.fi.intel.com>
Hi,
On 10/8/20 5:52 PM, Mika Westerberg wrote:
> On Thu, Oct 08, 2020 at 05:37:10PM +0200, Hans de Goede wrote:
>> Mika, do you have input wrt always calling _REG for just the
>> GpioIoOpRegion type (on top of the existing EC exception) vs
>> just simply always calling it for all all/more OpRegion types ?
>
> IMO it is safer to call it only for GPIO (GpioIoOpRegion) now.
That was my thought too, and is what my current patch does.
Thank you for your input on this.
Regards,
Hans
next prev parent reply other threads:[~2020-10-08 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 14:59 [PATCH v2] pinctrl: cherryview: Ensure _REG(ACPI_ADR_SPACE_GPIO, 1) gets called Hans de Goede
2020-05-06 6:40 ` Mika Westerberg
2020-05-07 10:15 ` Hans de Goede
2020-05-07 12:30 ` Mika Westerberg
2020-05-07 12:39 ` Hans de Goede
2020-05-07 13:39 ` Andy Shevchenko
2020-10-08 9:31 ` Hans de Goede
2020-10-08 14:44 ` Mika Westerberg
2020-10-08 15:37 ` Hans de Goede
2020-10-08 15:52 ` Mika Westerberg
2020-10-08 17:39 ` Hans de Goede [this message]
2020-05-06 23:42 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efcd512b-9072-5807-b7e6-79a2aa413273@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=erik.kaneda@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox