From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Zhang Rui <rui.zhang@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: [PATCH v2 3/9] ACPI-video: Delete an error message for a failed kzalloc() call
Date: Wed, 9 Aug 2017 17:38:12 +0200 [thread overview]
Message-ID: <f1a7dd48-312c-348b-be56-52f8263428af@users.sourceforge.net> (raw)
In-Reply-To: <d8cc6f88-9261-55d9-a736-a14b853a2570@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 9 Aug 2017 15:07:53 +0200
Omit an extra message for a memory allocation failure in this function.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/acpi/acpi_video.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index 7a9cda6c0a6b..f83ece9c830c 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -821,7 +821,6 @@ int acpi_video_get_levels(struct acpi_device *device,
br = kzalloc(sizeof(*br), GFP_KERNEL);
if (!br) {
- printk(KERN_ERR "can't allocate memory\n");
result = -ENOMEM;
goto out;
}
--
2.13.4
next prev parent reply other threads:[~2017-08-09 15:38 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <566ABCD9.1060404@users.sourceforge.net>
2015-12-25 10:35 ` ACPI-fan: Another source code review around null pointer handling? SF Markus Elfring
2016-09-05 16:42 ` [PATCH 00/21] ACPI-video: Fine-tuning for several function implementations SF Markus Elfring
2016-09-05 16:45 ` [PATCH 01/21] ACPI-video: Use kmalloc_array() in acpi_video_get_levels() SF Markus Elfring
2016-09-05 16:46 ` [PATCH 02/21] ACPI-video: Return directly after a failed device query SF Markus Elfring
2016-09-05 16:48 ` [PATCH 03/21] ACPI-video: Delete an error message for a failed kzalloc() call SF Markus Elfring
2016-09-05 16:50 ` [PATCH 04/21] ACPI-video: Rename jump labels in acpi_video_get_levels() SF Markus Elfring
2016-09-05 16:51 ` [PATCH 05/21] ACPI-video: Delete an unnecessary initialisation " SF Markus Elfring
2016-09-05 16:52 ` [PATCH 06/21] ACPI-video: Move four assignments " SF Markus Elfring
2016-09-05 16:53 ` [PATCH 07/21] ACPI-video: Rename jump labels in acpi_video_bus_add() SF Markus Elfring
2016-09-05 16:54 ` [PATCH 08/21] ACPI-video: Improve a size determination " SF Markus Elfring
2016-09-05 16:56 ` [PATCH 09/21] ACPI-video: Rename jump labels in acpi_video_register() SF Markus Elfring
2016-09-05 16:57 ` [PATCH 10/21] ACPI-video: Return directly after a failed input_allocate_device() SF Markus Elfring
2016-09-05 16:58 ` [PATCH 11/21] ACPI-video: Rename jump labels in acpi_video_bus_add_notify_handler() SF Markus Elfring
2016-09-05 16:59 ` [PATCH 12/21] ACPI-video: Delete unnecessary if statement in acpi_video_switch_brightness() SF Markus Elfring
2016-09-05 17:00 ` [PATCH 13/21] ACPI-video: Improve a jump target " SF Markus Elfring
2016-09-05 17:01 ` [PATCH 14/21] ACPI-video: Improve a size determination in acpi_video_device_enumerate() SF Markus Elfring
2016-09-05 17:02 ` [PATCH 15/21] ACPI-video: Delete an unnecessary initialisation " SF Markus Elfring
2016-09-05 17:03 ` [PATCH 16/21] ACPI-video: Rename jump labels " SF Markus Elfring
2016-09-05 17:04 ` [PATCH 17/21] ACPI-video: Delete an unnecessary initialisation in acpi_video_init_brightness() SF Markus Elfring
2016-09-05 17:05 ` [PATCH 18/21] ACPI-video: Rename jump labels " SF Markus Elfring
2016-09-05 17:06 ` [PATCH 19/21] ACPI-video: Rename a jump label in acpi_video_device_lcd_query_levels() SF Markus Elfring
2016-09-05 17:07 ` [PATCH 20/21] ACPI-video: Improve a size determination in acpi_video_dev_register_backlight() SF Markus Elfring
2016-09-05 17:09 ` [PATCH 21/21] ACPI-video: Improve a size determination in acpi_video_bus_get_one_device() SF Markus Elfring
2016-09-05 21:41 ` [PATCH 00/21] ACPI-video: Fine-tuning for several function implementations Rafael J. Wysocki
2016-09-06 3:28 ` SF Markus Elfring
2016-09-06 11:21 ` Rafael J. Wysocki
2016-09-06 14:10 ` SF Markus Elfring
2016-09-06 21:05 ` Rafael J. Wysocki
2016-09-07 6:40 ` SF Markus Elfring
2017-08-09 15:30 ` [PATCH v2 0/9] " SF Markus Elfring
2017-08-09 15:33 ` [PATCH v2 1/9] ACPI-video: Use kmalloc_array() in acpi_video_get_levels() SF Markus Elfring
2017-08-09 15:36 ` [PATCH v2 2/9] ACPI-video: Return directly after a failed device query SF Markus Elfring
2017-08-09 15:38 ` SF Markus Elfring [this message]
2017-08-09 15:40 ` [PATCH v2 4/9] ACPI-video: Return directly after a failed input_allocate_device() SF Markus Elfring
2017-08-09 15:41 ` [PATCH v2 5/9] ACPI-video: Delete unnecessary if statement in acpi_video_switch_brightness() SF Markus Elfring
2017-08-09 15:42 ` [PATCH v2 6/9] ACPI-video: Improve a jump target " SF Markus Elfring
2017-08-09 15:44 ` [PATCH v2 7/9] ACPI-video: Delete an unnecessary initialisation in three functions SF Markus Elfring
2017-08-09 15:45 ` [PATCH v2 8/9] ACPI-video: Move four assignments in acpi_video_get_levels() SF Markus Elfring
2017-08-09 15:47 ` [PATCH v2 9/9] ACPI-video: Improve a size determination in four functions SF Markus Elfring
2016-09-05 20:12 ` [PATCH 0/7] ACPI-APEI-HEST: Fine-tuning for three function implementations SF Markus Elfring
2016-09-05 20:15 ` [PATCH 1/7] ACPI-APEI-HEST: Fix a typo in a comment line SF Markus Elfring
2016-09-05 20:17 ` [PATCH 2/7] ACPI-APEI-HEST: Use kmalloc_array() in hest_ghes_dev_register() SF Markus Elfring
2016-09-05 20:18 ` [PATCH 3/7] ACPI-APEI-HEST: Move an assignment " SF Markus Elfring
2016-09-05 20:20 ` [PATCH 4/7] ACPI-APEI-HEST: Rename jump labels " SF Markus Elfring
2016-09-05 20:21 ` [PATCH 5/7] ACPI-APEI-HEST: Rename jump labels in acpi_hest_init() SF Markus Elfring
2016-09-05 20:22 ` [PATCH 6/7] ACPI-APEI-HEST: Reduce the scope for a variable " SF Markus Elfring
2016-09-05 20:23 ` [PATCH 7/7] ACPI-APEI-HEST: Rename jump labels in hest_parse_ghes() SF Markus Elfring
2016-09-05 21:43 ` [PATCH 0/7] ACPI-APEI-HEST: Fine-tuning for three function implementations Rafael J. Wysocki
2016-09-06 3:38 ` SF Markus Elfring
2016-09-06 11:25 ` Rafael J. Wysocki
2016-09-06 14:21 ` SF Markus Elfring
2017-08-09 18:00 ` [PATCH v2 0/4] ACPI-APEI-HEST: Fine-tuning for two " SF Markus Elfring
2017-08-09 18:01 ` [PATCH v2 1/4] ACPI-APEI-HEST: Fix a typo in a comment line SF Markus Elfring
2017-08-09 18:02 ` [PATCH v2 2/4] ACPI-APEI-HEST: Use kmalloc_array() in hest_ghes_dev_register() SF Markus Elfring
2017-08-09 18:03 ` [PATCH v2 3/4] ACPI-APEI-HEST: Move an assignment " SF Markus Elfring
2017-08-09 18:04 ` [PATCH v2 4/4] ACPI-APEI-HEST: Reduce the scope for a variable in acpi_hest_init() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1a7dd48-312c-348b-be56-52f8263428af@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).